Cleanup the Makefile of unused and obsolete build targets #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doanac this is rather opinionated. But we've made so many changes to Makefile recently, that it is worth finishing this story. |
vkhoroz
commented
Oct 6, 2023
vkhoroz
changed the title
doanac
approved these changes
Oct 6, 2023
It does not build in Golang 1.19 compiler and higher. A correct way to specify the Arm version is via the GOARM environent variable. Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
All fioctl-% build targets are already static. Moreover, this target is kind of misleading: - It sets CGO_ENABLED=0 which forces to use internal linker. - But, it then passes `extldflags` which are only relevant for external linker, i.e. they are ignored. Anyway, it is redundant, so better get rid of it. Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
We never use it, meaning we never test it. Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
vkhoroz
force-pushed
the
vkhoroz-clean-makefile
branch
from
cd92a43
to
7fc4703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.