Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freaky Freekeh #37

Merged
merged 5 commits into from
Feb 14, 2018
Merged

Freaky Freekeh #37

merged 5 commits into from
Feb 14, 2018

Conversation

Suuuuha
Copy link
Contributor

@Suuuuha Suuuuha commented Sep 7, 2017

update 7/1/18 by @mattlub:

  • PR reopened again
  • recipe added by sous-chef
  • still WIP because awaiting check on quantites/method from main-chef @Suuuuha

update 29/1/18:

  • READY FOR REVIEW

@mattlub
Copy link
Contributor

mattlub commented Sep 25, 2017

...

@Karyum
Copy link
Contributor

Karyum commented Sep 29, 2017

I think this is literally the smallest pull request i have ever seen 😆

@@ -0,0 +1 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karyum
Copy link
Contributor

Karyum commented Oct 28, 2017

@Suuuuha @mattlub @m4v15 for the lack of contributions to this PR would probably be a good idea to close.
BY THE POWER GIVEN BY THEE
or something like that

@Karyum Karyum closed this Oct 28, 2017
@mattlub
Copy link
Contributor

mattlub commented Nov 6, 2017

reopening and assigning to @Suuuuha because I would like to cook this.

@mattlub mattlub reopened this Nov 6, 2017
@Karyum
Copy link
Contributor

Karyum commented Nov 6, 2017

@matthewdking is using Suha's requested change in my PR as an argument in where i can't merge the Arabic Omelette.

So im using this PR just to state that Arabic Omelette would have been never merged if we waited for other people

and @m4v15 i believe there is nothing you could here. GO read the contribution file and see what it says
and then check my PR

@m4v15
Copy link
Contributor

m4v15 commented Nov 6, 2017

I don't think this is the place for this discussion... however, in the contributing guide:

A PR should never be merged if a reviewer has requested changes and not yet re-reviewed it.

Happy?

@Karyum
Copy link
Contributor

Karyum commented Nov 6, 2017

@m4v15 I know mate it says that but at look at this. You can't use PRs as issues mate you can't just open an empty PR just to add some stuff later . for me this is considered even worse than pushing to master, cause there is a few reasons why you might push to master, but there is no reason behind this mate

@m4v15
Copy link
Contributor

m4v15 commented Nov 6, 2017

Yeah to be honest I'm not sure how I feel about this PR being used as it is but that is a completely separate issue to you merging your own PR, not sure why you are conflating them.

@Karyum
Copy link
Contributor

Karyum commented Nov 6, 2017

@m4v15 Im just showing you my reasoning behind skipping @Suuuuha review (which is the same review that @matthewdking borught up)

@Karyum
Copy link
Contributor

Karyum commented Jan 5, 2018

I'm sorry but this has to happen at some point 🤣

@Karyum Karyum closed this Jan 5, 2018
@Karyum Karyum deleted the Freaky_Freekeh branch January 5, 2018 19:12
@mattlub
Copy link
Contributor

mattlub commented Jan 6, 2018

@Karyum I will reopen this at some point and complete it myself if needs be. MARK MY WORDS :shipit:

@Karyum
Copy link
Contributor

Karyum commented Jan 6, 2018

@mattlub both of you guys are pretty busy people, so pretty sure nothing would get done 😆

@mattlub mattlub restored the Freaky_Freekeh branch January 7, 2018 17:28
@mattlub mattlub reopened this Jan 7, 2018
- flaked almonds, and/or other nuts of your choice

## Method
- cover the freekeh with water a leave for a couple of minutes until it absorbs the water
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and*

@Suuuuha
Copy link
Contributor Author

Suuuuha commented Jan 10, 2018

@mattlub sweeeet ❤️
just fix the typo and :shipit:

@mattlub mattlub changed the title {WIP} Freaky Freekeh Freaky Freekeh Jan 29, 2018
@Karyum
Copy link
Contributor

Karyum commented Jan 29, 2018

@mattlub did you actually just approve changes that you made ? this is nonsense i call BS 🤣

# Freaky Freekeh

![Difficulty Badge](https://img.shields.io/badge/Difficulty-20%25-green.svg)
![Speed Badge](https://img.shields.io/badge/Speed-0.3hrs-brightgreen.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3hrs ? what is that all about ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you think it should be in minutes?

![Cost Badge](https://img.shields.io/badge/Cost-Cheap-green.svg)
![Serves Badge](https://img.shields.io/badge/Serves-8-green.svg)
![Reception Badge](https://img.shields.io/badge/Reception-Positive-green.svg)
![Green Badge Count Badge](https://img.shields.io/badge/Green%20badge%20count-100%25-green.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not badge that you should include by the (CONTRIBUTING.md)[https://github.com/foundersandcoders/nazareth-recipes/blob/master/CONTRIBUTING.md] guide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not required but the guide says "Feel free to add other any badges you deem appropriate!"


+ **Chef:** Suha
+ **Sous:** Lubes
+ **Date:** Week 12 FACN2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait what ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we had the barbecue on the balcony, remember?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel old 😢

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back in those wild teenage days...

+ **Date:** Week 12 FACN2

## Ingredients
- 3 mugs of freekeh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there all kinds of mugs with different shapes and sizes, so how much is a mug ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 mug is more-or-less the size of 1 average-sized mug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how much is an averaged-sized mug 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you want me to change it to? cups? :D

- Add the freekeh, and cover with 3 mugs-worth of boiling water. Simmer gently, adding more water if necessary, tasting it regularly until it is ready. **Suha's Special Tip:** Be careful not to add too much water!
- Fry or roast the flaked almonds, and serve them sprinkled on top of the freekeh.

## Comments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case people want to add comments, e.g. after they cook it or what they thought of it

@mattlub mattlub requested a review from sofer January 29, 2018 20:52
@mattlub
Copy link
Contributor

mattlub commented Feb 14, 2018

@m4v15 @Karyum @matthewdking review + merge pls, this recipe needs to be shipped 🚢 🇮🇹

@Karyum Karyum merged commit 0d3e79b into master Feb 14, 2018
@Karyum Karyum deleted the Freaky_Freekeh branch February 14, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants