Skip to content

This App is in a Right State #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 16, 2025
Merged

This App is in a Right State #20

merged 19 commits into from
Jun 16, 2025

Conversation

@JasonWarrenUK
Copy link
Collaborator

@JasonWarrenUK JasonWarrenUK commented Jun 16, 2025 •
edited
Loading

I WILL WRITE DETAILS LATER/TOMORROW, but I wanted to get this PR up for @AlexVOiceover

Overview

Connects the dashboard all the way through to the Question Card component, using the app state all the way through.

TL;DR

  • From here on, all connective logic goes via the app state in the context
const app:App = $state({
  /* everything */
})
  • Probably need to reset the DB, genuinely can't remember at this point...

Changes

I'm sorry, there's simply no way of describing all the changes in detail.

  • Every Svelte file edited to use the state
  • Loads of new types
  • All utility functions moved into separated modules

Summary

This PR is a rabid dog that, nevertheless, won Crufts

@JasonWarrenUK
refactor(state): 🏗️ create a unified app state in layout
c4c97d2
@JasonWarrenUK
refactor(state): 🚧 call dash through app
5319150
@JasonWarrenUK
chore(dev mode): 🧑‍💻 create StateTable dev component
68bac5a
@JasonWarrenUK
refactor(state): 🚧 invite <List /> to the $state(app) party
bd25ebb
@JasonWarrenUK
Merge branch 'main' of https://github.com/foundersandcoders/LIFT02 in…
56cbb50 
…to feat/link-list-to-detail
@JasonWarrenUK
style(dev mode): 💄 rationalise the dev table
22c3741
@JasonWarrenUK
fix(types): 🏷️ simplify types
f098ea8
@JasonWarrenUK
feat(utils): 🧑‍💻 expand makePretty()
4f41a6e
@JasonWarrenUK
fix(types): 🚧 drive state through component chain
7e5ed34
@JasonWarrenUK
refactor(types): 🏷️ rename App to AppState in views
f2c1267
@JasonWarrenUK
refactor(props): make Dash tile onclick handlers easier to parse
cb24595
@JasonWarrenUK
perf(state): combine state setters into bundle functions
256051b
@JasonWarrenUK
feat(state): hand slimmest state possible to Header, Dash & Footer
be88a9d
@JasonWarrenUK
feat(state): pass state into list questions
d501814
@JasonWarrenUK
feat(state): load the correct QuestionCard
36e6e63
@JasonWarrenUK
feat(state): ✨ move all logic from questionCard to appState
6d25ed6
@JasonWarrenUK
Merge branch 'main' of https://github.com/foundersandcoders/LIFT02 in…
4b49076 
…to feat/link-list-to-detail
@JasonWarrenUK
fix: 🔀 fix conflicts between branches
1a4c64f
AlexVOiceover
AlexVOiceover approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@AlexVOiceover AlexVOiceover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this was a massive one. Merging

@AlexVOiceover AlexVOiceover merged commit 3af12a7 into main Jun 16, 2025
1 check passed
@AlexVOiceover AlexVOiceover deleted the feat/link-list-to-detail branch June 16, 2025 17:48
AlexVOiceover added a commit that referenced this pull request Nov 1, 2025
@AlexVOiceover
fix(ui): remove italics and update manager actions field text
444db02 
Issue #18:
- Remove italic styling from action question preview text in app.css
- Remove italic class from font size control icon
- Remove italic class from help modal screenshot captions

Issue #20:
- Update manager actions field text from 'Manage actions...' to 'The actions...'
- Clean up Tooltip formatting in ActionsCRUD component

- Update TESTING_ISSUES.md to mark Issues #18 and #20 as fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexVOiceover AlexVOiceover AlexVOiceover approved these changes

@Jaz-spec Jaz-spec Awaiting requested review from Jaz-spec

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JasonWarrenUK @AlexVOiceover