Skip to content

Commit 444db02

Browse files
committed
fix(ui): remove italics and update manager actions field text
Issue #18: - Remove italic styling from action question preview text in app.css - Remove italic class from font size control icon - Remove italic class from help modal screenshot captions Issue #20: - Update manager actions field text from 'Manage actions...' to 'The actions...' - Clean up Tooltip formatting in ActionsCRUD component - Update TESTING_ISSUES.md to mark Issues #18 and #20 as fixed
1 parent d2d7008 commit 444db02

File tree

5 files changed

+16
-11
lines changed

5 files changed

+16
-11
lines changed

docs/TESTING_ISSUES.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,14 @@ Track testing issues and their resolution status. Work through these one by one,
140140
---
141141

142142
### Issue #18 - Remove italics
143-
- [ ] **Status**: Not started
143+
- [x] **Status**: ✅ Fixed
144144
- **Description**: Remove all use of italics across the site
145145
- **Location**: All pages
146-
- **Files affected**: TBD
146+
- **Files affected**:
147+
- `src/app.css` (line 321)
148+
- `src/lib/components/ui/FontSizeControl.svelte` (line 107)
149+
- `src/lib/components/ui/HelpModal.svelte` (line 85)
150+
- **Solution**: Removed `italic` class/styling from action question preview text, font size control icon, and help modal screenshot captions
147151

148152
---
149153

@@ -167,4 +171,4 @@ Track testing issues and their resolution status. Work through these one by one,
167171

168172
- **Total Issues**: 17
169173
- **Completed**: 7
170-
- **Remaining**: 9 (1 rejected)
174+
- **Remaining**: 9 (1 rejected - Issue 5)

src/app.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ h3 {
318318
}
319319

320320
.action-question-preview {
321-
@apply text-sm whitespace-nowrap text-gray-500 italic;
321+
@apply text-sm whitespace-nowrap text-gray-500;
322322
}
323323

324324
.action-separator {

src/lib/components/ui/ActionsCRUD.svelte

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@
201201
<div class="actions-crud">
202202
<div class="actions-header">
203203
<h4 class="form-label">
204-
Manage actions you'd like your manager to take in response to this question.
204+
The actions you'd like your manager to take in response to this question.
205205
</h4>
206206
</div>
207207

@@ -321,7 +321,10 @@
321321
</div>
322322
</div>
323323
{:else}
324-
<Tooltip text={!responseId ? "Save your response first to add actions" : "Add a new action"} position="top_right">
324+
<Tooltip
325+
text={!responseId ? 'Save your response first to add actions' : 'Add a new action'}
326+
position="top_right"
327+
>
325328
<button
326329
onclick={() => (showNewActionForm = true)}
327330
class="btn-submit btn-sm"
@@ -331,9 +334,7 @@
331334
</button>
332335
</Tooltip>
333336
{#if !responseId}
334-
<p class="text-sm text-base-content/70 mt-2">
335-
💡 Save your response first to add actions
336-
</p>
337+
<p class="text-base-content/70 mt-2 text-sm">💡 Save your response first to add actions</p>
337338
{/if}
338339
{/if}
339340
</div>

src/lib/components/ui/FontSizeControl.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
<span class="text-sm leading-none">+</span>
105105
<span class="text-sm leading-none">-</span>
106106
</div>
107-
<span class="italic font-serif text-lg leading-none">A</span>
107+
<span class="font-serif text-lg leading-none">A</span>
108108
</div>
109109
</button>
110110
</Tooltip>

src/lib/components/ui/HelpModal.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
</p>
8383
</div>
8484
{#if section.screenshot.caption}
85-
<p class="text-sm text-base-content/70 mt-2 italic text-center">{section.screenshot.caption}</p>
85+
<p class="text-sm text-base-content/70 mt-2 text-center">{section.screenshot.caption}</p>
8686
{/if}
8787
</div>
8888
{/if}

0 commit comments

Comments
 (0)