Add GitHub Workflow for Linting , Formatting and Test. Activate Workflow for Framework #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianlim
force-pushed
the
lint
branch
2 times, most recently
from
91b35e0
to
2826ad2
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
changed the title
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
changed the title
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
achew010
approved these changes
May 17, 2024
This was referenced May 20, 2024
fabianlim
added a commit
that referenced
this pull request
May 27, 2024
…or GPTQ-LoRA (#20) * Add GitHub Workflow for Linting , Formatting and Test. Activate Workflow for Framework (#7) * add lint workflow Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * add pylintrc, update .tox fix files Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * activate test and minor fix Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * lint benchmarks.py and add workflow to dev Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> --------- Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * Improvements to Benchmark Scripts and Config Generation Workflow (#13) * fix benches and add verify configs Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * update readme and add workflow Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * add packaging dep Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * update torch dep in framework and run-benches Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * take host env in run-benches * add display bench results script * rename summary.csv to raw_summary.csv and update run_benchmarks.sh * export environment variables in shell command * dump out pip requirements for repro, and add default FHT_branch --------- Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * Added support for running official HF baseline FSDP-QLoRA benchmark (#16) * new baseline scenario * rename variables * added warning when plugin allows SFTTrainer to handle PEFT on single device * Fix FSDP when performing GPTQ-LoRA with Triton V2 (#15) * wrap in parameters and torch view to correct dtype Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * refactor to apply patch only on FSDP and simplify Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> --------- Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * Provide Memory Benchmarking Feature to Benchmarking Code (#14) * add gpu memory logging support * made improvements to GPU reference and result collation * Renamed memory logging argument to reflect its readings as reserved me mory using nvidia-smi and changed aggregation function in result collation * variable renames * manual linting * added memory logging functionality via HFTrainer * added support to benchmark memory using HFTrainer and updated READMEwith explanation of the 2 memory benchmarking options * addressed changes requested in PR #14 * fix bug and smplify gpu logs aggregation logic * fixes to calculation of HFTrainer Mem Logging values * fix calculations * more fixes * fix to ignore including stage inside max calculation of alloc memory * more comments and README updates * added fix to keyerror due to empty output dict from OOM * manual linting * added benchmark results to refs * remove unnecessary columns in results gathering * made changes to results gathering --------- Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> Co-authored-by: achew010 <165894159+achew010@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
plugins/frameworkplugins/frameworkThere should be a separate task to fix files for
scripts/plugins/accelerated-peft