activate test and minor fix

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
foundation-model-stack · May 15, 2024 · c941faf · c941faf
1 parent 630dd42
commit c941faf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -47,3 +47,7 @@ jobs:
         run: |
           cd plugins/${{ matrix.plugin_name }}
           tox -e fmt
+      - name: Run pytest
+        run: |
+          cd plugins/${{ matrix.plugin_name }}
+          tox -e py
diff --git a/plugins/framework/tests/test_framework.py b/plugins/framework/tests/test_framework.py
@@ -272,14 +272,16 @@ def test_plugin_registration_order():
 
     # build a set of hooks that register the activation order
     def hook_builder(act_order=None):
+
+        if act_order is None:
+            act_order = []
+
         def _hook(
             self,
             model,
             train_args,
             modifiable_args,
         ):
-            if act_order is None:
-                act_order = []
             act_order.append(str(self.__class__))
             return model, modifiable_args