Fixes issue #69 : Enhanced feedback to Selection/Deselection of CheckBox

[Preeti9764]

Fixes issue #69

Changes:

• Improved feedback when selecting/deselecting checkboxes.
• Modified src/index.css and src/scripts/main.js to enhance UI responsiveness.
• Now, when a checkbox is selected/deselected, users get clearer visual feedback.

Summary by Sourcery

Enhance user feedback for checkbox interactions by adding visual styling to improve UI responsiveness

Bug Fixes:

• Improve user experience by adding visual cues for checkbox state changes

Enhancements:

• Implement dynamic label styling for checkboxes to provide clearer visual feedback when selected or deselected

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request enhances the user experience by providing visual feedback when checkboxes are selected or deselected. It modifies the JavaScript code to toggle CSS classes on the associated label elements, and it adds new CSS classes to define the styles for the selected and deselected states. A transition effect was added for a smoother user experience.

Updated class diagram for label elements

classDiagram
  class HTMLLabelElement {
    +string className
    +add(string className)
    +remove(string className)
  }

  note for HTMLLabelElement "Added 'selectedLabel' and 'unselectedLabel' classes to provide visual feedback"

Loading

File-Level Changes

Change	Details	Files
Added visual feedback to checkbox selection/deselection by toggling CSS classes on the associated label.	Added 'selectedLabel' and 'unselectedLabel' classes to src/index.css to define the visual styles for selected and deselected states. Modified the checkbox change handlers in src/scripts/main.js to toggle these classes on the corresponding label element. Added a transition effect for color and font-weight changes on the labels for a smoother user experience.	src/scripts/main.js src/index.css

Possibly linked issues

• UI Issue with Checkbox Selection/Deselection Feedback #69: The PR fixes the checkbox selection/deselection feedback issue by modifying src/index.css and src/scripts/main.js to enhance UI responsiveness.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Preeti9764 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using a more descriptive class name than selectedLabel and unselectedLabel.
• It looks like the handleOpenLabelChange function is setting the same value for both showOpenLabel and showClosedLabel - is that intentional?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (complexity): Consider creating a helper function to toggle the label classes to reduce code duplication in the handleLastWeekContributionChange and handleOpenLabelChange functions

You can reduce duplication by extracting the label toggling logic into a helper function. For example:

function updateLabelClass(labelElement, isSelected) {
  labelElement.classList.toggle("selectedLabel", isSelected);
  labelElement.classList.toggle("unselectedLabel", !isSelected);
}

Then update your handlers to use the helper:

function handleLastWeekContributionChange() {
  var value = lastWeekContributionElement.checked;
  var labelElement = document.querySelector("label[for='lastWeekContribution']");
  if (value) {
    startingDateElement.disabled = true;
    endingDateElement.disabled = true;
    endingDateElement.value = getToday();
    startingDateElement.value = getLastWeek();
    updateLabelClass(labelElement, true);
    handleEndingDateChange();
    handleStartingDateChange();
  } else {
    startingDateElement.disabled = false;
    endingDateElement.disabled = false;
    updateLabelClass(labelElement, false);
  }
  chrome.storage.local.set({ lastWeekContribution: value });
}

function handleOpenLabelChange() {
  var value = showOpenLabelElement.checked;
  var labelElement = document.querySelector("label[for='showOpenLabel']");
  updateLabelClass(labelElement, value);
  chrome.storage.local.set({ showOpenLabel: value });
}

This removes duplicated code while keeping functionality intact.

[Preeti9764]

@hongquan hey can you review my PR and guide me on any further changes required, I find this project really interesting and would love to contribute further.

[Preeti9764]

@mariobehling @hongquan Please have a look and suggest some changes and guide for further improvement in UI .

[vedansh-5]

fix the mentioned calls and the PR is good to be merged.

[vedansh-5]

You seem to have removed these function calls from handleLastWeekContributionChange().
These are required to change the dates accordingly.

[Preeti9764]

Thanks for catching that! I've re-added the handleEndingDateChange() and handleStartingDateChange() calls.

[vedansh-5]

lgtm! Thanks @Preeti9764

[Preeti9764]

@mariobehling, please have a look at this pr and suggest to me further changes I could do