Skip to content

Scrum subject and body message are now correctly added in Outlook #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

vedansh-5
Copy link
Contributor

@vedansh-5 vedansh-5 commented Apr 6, 2025

Closes #80
Changes: The selectors of outlook are updated in the latest changes and now works properly by injecting the scrum body in the body area and subject in the subject area.

Screenshots for the change:
image

Summary by Sourcery

Bug Fixes:

  • Fix Outlook email client selector issues by updating the body and subject element selectors to match the latest Outlook web interface

Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
Copy link
Contributor

sourcery-ai bot commented Apr 6, 2025

Reviewer's Guide by Sourcery

This pull request updates the selectors for Outlook to ensure the proper injection of scrum data into the body and subject fields. The selectors for the body and subject input fields have been updated to reflect the latest changes in Outlook's UI.

Updated class diagram for EmailClientAdapter

classDiagram
  class EmailClientAdapter {
    -emailClient
    +constructor(emailClient: string)
    +getSelectors(): object
    +getEventTypes(): object
    +inject(body: string, subject: string): void
  }
  EmailClientAdapter -- OutlookSelectors : has a
  class OutlookSelectors{
    -body: string
    -subject: string
  }
  note for OutlookSelectors "Selectors for Outlook were updated"
  OutlookSelectors -- string : body
  OutlookSelectors -- string : subject
Loading

File-Level Changes

Change Details Files
Updated Outlook selectors to target the correct body and subject input fields.
  • Updated the body selector to target the 'Message body' with the correct aria-label.
  • Updated the subject selector to target the 'Subject' input field with the correct aria-label.
src/scripts/emailClientAdapter.js

Assessment against linked issues

Issue Objective Addressed Explanation
#80 The Scrum Helper Extension should inject the generated Scrum summary into the body of Outlook emails.
#80 The Scrum Helper Extension should inject the generated Scrum subject into the subject of Outlook emails.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vedansh-5 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the selectors changed, possibly referencing the Outlook update.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@vedansh-5
Copy link
Contributor Author

vedansh-5 commented Apr 14, 2025

@hongquan Waiting for your review, please have a look whenever you have some time.

@vedansh-5
Copy link
Contributor Author

@mariobehling @hongquan this pr solves the outlook bug, could you have a look whenever you have some time.

@vedansh-5
Copy link
Contributor Author

@hongquan Could you take a look at this PR, this solves the current outlook bug.

Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
@mariobehling mariobehling requested a review from hongquan May 23, 2025 09:28
@vedansh-5
Copy link
Contributor Author

This PR successfully solves the outlook bug ensuring proper body and subject injection.

@mariobehling mariobehling changed the title outlook bug Scrum subject and body message are now correctly added in Outlook May 23, 2025
@mariobehling mariobehling merged commit a38a196 into fossasia:master May 23, 2025
Preeti9764 added a commit to Preeti9764/scrum_helper that referenced this pull request May 25, 2025
Scrum subject and body message are now correctly added in Outlook (fossasia#81)
Preeti9764 added a commit to Preeti9764/scrum_helper that referenced this pull request May 25, 2025
Scrum subject and body message are now correctly added in Outlook (fossasia#81)
@vedansh-5 vedansh-5 deleted the outlookBug branch May 29, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Scrum content appearing in TO field on Outlook
2 participants