Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the crash on opening of ROBOTIC ARM #2281

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Fix the crash on opening of ROBOTIC ARM #2281

merged 1 commit into from
Nov 7, 2021

Conversation

suman-somu
Copy link
Member

Fixes #2280

Changes:

changed from android to androidx packages

Screen shots for the changes:

Record_2021-11-07-08-42-20.mp4

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding any value.
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml.
  • I have reformatted code and fixed indentation in every file included in this pull request
  • My code does not contain any extra lines or extra spaces.
  • I have requested reviews from maintainers.

@suman-somu
Fix the crash on opening of ROBOTIC ARM
6cc1acc 
changed from android to androidx packages
@suman-somu
Copy link
Member Author

@CloudyPadmal
i have changed the andoid packages to androidx of the robotic arm
i think, this should have been done in the pr #2254 , but might be missed.
can you please review this pr .
thank you.

CloudyPadmal
CloudyPadmal approved these changes Nov 7, 2021
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 👍

@CloudyPadmal CloudyPadmal merged commit 4c81aad into fossasia:development Nov 7, 2021
@suman-somu
Copy link
Member Author

you r welcome :D

@suman-somu
Copy link
Member Author

@CloudyPadmal
also, do will i close the issue ( which is fixed in this pr) or it will close automatically or something else ?

@CloudyPadmal
Copy link
Collaborator

It should be closed when referred here. Strangely it hasn't. Let me close it.

@CloudyPadmal CloudyPadmal mentioned this pull request Nov 7, 2021
Closed
@suman-somu
Copy link
Member Author

yeah .

okay

@suman-somu suman-somu deleted the patch1 branch November 7, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suman-somu @CloudyPadmal