Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all Files to AndroidX for the issue #2242 #2254

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Update all Files to AndroidX for the issue #2242 #2254

merged 1 commit into from
Oct 15, 2021

Conversation

MohitGupta121
Copy link
Member

Fixes #2242

Changes:

  • Change all the files to AndroidX.

@MohitGupta121
Copy link
Member Author

MohitGupta121 commented Oct 14, 2021

@CloudyPadmal I have Change all the files into AndroidX, Can you please review it.

But I try so much to git squash the commit, but I don't know why this not done.

I follow all the documentation given by you and from other blogs but it Squash in my local git log but not in pull request.

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MohitGupta121 the PR is all good and squashed. Job well done!

@CloudyPadmal CloudyPadmal merged commit dd0d0f1 into fossasia:development Oct 15, 2021
@MohitGupta121
Copy link
Member Author

@CloudyPadmal Thanks you I try it last night and I'll fix the squashed.

@CloudyPadmal
Copy link
Collaborator

It is squashed already. May be you didn't see that there's only one commit.

@MohitGupta121
Copy link
Member Author

MohitGupta121 commented Oct 15, 2021

No, I squashed it at night with lots of efforts, there is 16 commits when I'll make pull request.

But I'm its really good to seee the squashed commit and clean PR.
Anyways Now I understand how to squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants