Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat #2086: Add Ripple effect on Card in Dashboard #2087

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

dheerajkotwani
Copy link
Member

Fixes #2086: Add Ripple effect for click on Card on Dashborad

Changes: Previously there was no effect when cards on the Dashboard were clicked. Now ripple effect occurs when card is clicked

Screenshot/s for the changes:
ps

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

@CloudyPadmal CloudyPadmal merged commit dbf0d69 into fossasia:development Jan 22, 2020
@CloudyPadmal CloudyPadmal added the Enhancement Improvement to an existing feature label Jan 22, 2020
@dheerajkotwani dheerajkotwani deleted the patch-1 branch January 22, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No effect is present on click any card on Dashboard
2 participants