Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bluetooth wifi connection option moved to Connect device menu #1952

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

neel1998
Copy link
Member

Fixes #1934
Changes: bluetooth wifi connection option moved to Connect device menu

Screenshot/s for the changes:
20190820_010404

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
wifi_bluetooth.zip

@neel1998 neel1998 added the Enhancement Improvement to an existing feature label Aug 19, 2019
@neel1998 neel1998 requested a review from CloudyPadmal August 19, 2019 19:38
@neel1998 neel1998 self-assigned this Aug 19, 2019
@neel1998 neel1998 force-pushed the wifi_bluetooth_option branch from 1b96372 to 36a675d Compare August 20, 2019 16:40
@neel1998
Copy link
Member Author

@CloudyPadmal made the requested changes

@CloudyPadmal CloudyPadmal merged commit 4e89f60 into fossasia:development Aug 20, 2019
@neel1998 neel1998 deleted the wifi_bluetooth_option branch August 27, 2019 13:57
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to connect over wifi/bluetooth to device screen and link to device icon to device screen
2 participants