chore(deps): upgraded glide to 4.10.0 #2891
Conversation
| } | ||
|
|
||
| private MediaSignature(String path, long lastModified) { | ||
| new ObjectKey(path + lastModified); |
There was a problem hiding this comment.
confused in this, what shall we do here?
app/build.gradle
Outdated
| annotationProcessor "com.jakewharton:butterknife-compiler:$rootProject.butterknifeVersion" | ||
| implementation 'com.github.bumptech.glide:glide:3.7.0' | ||
| implementation 'com.github.bumptech.glide:glide:4.10.0' | ||
| implementation group: 'com.github.bumptech.glide', name: 'gifencoder-integration', version: '4.10.0' |
There was a problem hiding this comment.
? means I have to add a variable in project-level gradle ?
codedsun
force-pushed
the
glide
branch
2 times, most recently
from
7fd50c1 to
1683631
Compare
app/build.gradle
Outdated
| annotationProcessor "com.jakewharton:butterknife-compiler:$rootProject.butterknifeVersion" | ||
| implementation 'com.github.bumptech.glide:glide:3.7.0' | ||
| implementation "com.github.bumptech.glide:glide:$rootProject.glideVersion" | ||
| implementation group: 'com.github.bumptech.glide', name: 'gifencoder-integration', version: "$rootProject.glideVersion" |
There was a problem hiding this comment.
Why are you writing it this way?
There was a problem hiding this comment.
Because gifencoder class was not available in the glide dependency, I had to import that externally by mentioning the dependency and the name.
Reference
https://mvnrepository.com/artifact/com.github.bumptech.glide/gifencoder-integration/4.9.0
There was a problem hiding this comment.
So, why are you writing it this way?
There was a problem hiding this comment.
Okay updated, check!
There was a problem hiding this comment.
Maven suggests this way of adding dependency :P
There was a problem hiding this comment.
@iamareebjamal Check and merge
2 participants
Fixed #2852 :
upgraded glide to 4.10.0
Changes: Refactor the code and replaced the old and depreciated implementations with new ones.
Screenshots of the change: