Update Glide to 4.x.x

[TacoTheDank]

Describe the chore

Update Glide from 3.x.x to 4.x.x

https://github.com/bumptech/glide/releases
https://bumptech.github.io/glide/doc/migrating.html

Would you like to work on the issue?

• Yes
• No
• Other: Someone who has the know-how can do this :)

[yashk2000]

@iamareebjamal while migrating to version 4, I cannot find a replacement for AnimatedGifEncoder. Could you please tell me if there is an alternative to this in version 4, or do we need to keep using version 3?

[iamareebjamal]

It's supported by default I guess

[yashk2000]

@iamareebjamal when I change to glide 4.9.0, this import com.bumptech.glide.gifencoder.AnimatedGifEncoder; stops working and it shows gifencoder not found.

[iamareebjamal]

Yeah because it is not needed now

[yashk2000]

But we are using AnimatedGifEncoder in phimpme.

[iamareebjamal]

For what?

[TacoTheDank]

@yashk2000
It still exists as far as I can tell: https://bumptech.github.io/glide/javadocs/490/index.html "com.bumptech.glide.gifencoder"

Edit: Found it https://mvnrepository.com/artifact/com.github.bumptech.glide/gifencoder-integration/4.9.0

[yashk2000]

@TacoTheDank thanks 👍

[yashk2000]

@iamareebjamal on updating the version to 4.9.0, we need to make a lot of changes. We also need to make changes in some of the custom animation modules. So should we update to 4.x.x or keep it to the current 3.7.x version?

[iamareebjamal]

Your choice

[TacoTheDank]

I mean, the longer we use old dependencies, the harder upgrading will potentially be later when we will eventually have to upgrade (either from adding new features, or other changes that may come along). I'd say we should tackle the old dependency issue sooner rather than later, I guess.

[codedsun]

i have completed this issue and upgraded the dependency to 4.10.0, sending a pr shortly!