Skip to content

refactor about activity code and layout with camelcase convention #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 1, 2019
Merged

refactor about activity code and layout with camelcase convention #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3ceeda
refactor about activity code and layout with camelcase convention
Sep 26, 2019
371a35d
refactor about activity code and layout with camelcase convention
Sep 26, 2019
6360cdb
Merge branch 'about' of https://github.com/codedsun/phimpme-android i…
Sep 26, 2019
0975ae1
Merge branch 'about' of https://github.com/codedsun/phimpme-android i…
Sep 26, 2019
9bb3604
Merge branch 'about' of https://github.com/codedsun/phimpme-android i…
Sep 26, 2019
26ce4b1
Merge branch 'about' of https://github.com/codedsun/phimpme-android i…
Sep 26, 2019
834fd37
Merge branch 'about' of https://github.com/codedsun/phimpme-android i…
Sep 27, 2019
7c04746
Merge branch 'about' of https://github.com/codedsun/phimpme-android i…
Sep 27, 2019
aaa00cd
Merge branch 'about' of https://github.com/codedsun/phimpme-android i…
Sep 27, 2019
c021e46
Merge branch 'development' into about
Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,17 +269,14 @@
<category android:name="android.intent.category.DEFAULT" />
</intent-filter>
</activity>

<activity
android:name=".gallery.activities.AboutActivity"
android:configChanges="orientation|screenSize"
android:label="@string/about"
android:theme="@style/Theme.AppCompat.NoActionBar">
<intent-filter>
Copy link
Member

@yashk2000 yashk2000 Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is removing this really needed?

Copy link
Contributor Author

@codedsun codedsun Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashk2000 Why is this added?

<action android:name="android.intent.action.ABOUT" />

<category android:name="android.intent.category.DEFAULT" />
</intent-filter>
</activity>

<activity
android:name=".gallery.activities.ExcludedAlbumsActivity"
android:label="@string/excluded_albums"
Expand Down
Loading