refactor about activity code and layout with camelcase convention #2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 26, 2019 21:51
|
@yashk2000 please review |
|
@iamareebjamal Please check |
yashk2000
reviewed
Sep 27, 2019
|
|
||
| /** Created by Jibo on 02/03/2016. */ | ||
| public class AboutActivity extends ThemedActivity { | ||
| /** Created by codedsun on 26/9/2019. */ |
yashk2000
reviewed
Sep 27, 2019
| android:configChanges="orientation|screenSize" | ||
| android:label="@string/about" | ||
| android:theme="@style/Theme.AppCompat.NoActionBar"> | ||
| <intent-filter> |
There was a problem hiding this comment.
Is removing this really needed?
There was a problem hiding this comment.
@yashk2000 Why is this added?
|
Please provide screenshots of the change if any. |
added 2 commits
September 27, 2019 12:16
|
@yashk2000 Review |
iamareebjamal
requested changes
Sep 27, 2019
|
@iamareebjamal Okay, will update! |
added 2 commits
September 27, 2019 16:44
|
@iamareebjamal @yashk2000 Please get this done! |
yashk2000
approved these changes
Sep 28, 2019
|
@iamareebjamal Please get this merged! |
|
@iamareebjamal @yashk2000 Please merge |
iamareebjamal
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2875 : refactor about activity code and layout with camelcase convention
Changes: Followed camelCase and removed unnecessary views, simplified view hierarchy with constraint layout
Screenshots of the change: