-
Notifications
You must be signed in to change notification settings - Fork 914
Fix for issue#2363: Option added for user to give permissions from app settings. #2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Shouldn't we make the app close on pressing OK? |
|
@angmas1 I've already sent a pull request for adding an exit button. When that'll be merged, there will be a separate button for the exiting the app. |
|
Cool, no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the ok button
|
@abishekvashok should I close #2412 and update this pull request with the exit button? |
|
@abishekvashok I have made the changes and also added the exit button. |
|
Can you give a gif and close the old pr? |
|
@abishekvashok I already have closed the old pull request. GIF of the change: |
|
Thanks |
…p settings. (fossasia#2428) Fix for issue fossasia#2363: Option added for user to give permissions from app settings.


Fixed #2363, #2411
Changes: When the dialog is shown to the user to give permissions, the user has the option to go to app settings and grant permissions from there.
GIF of the change: