Skip to content

Conversation

@yashk2000
Copy link
Member

@yashk2000 yashk2000 commented Jan 20, 2019

Fixed #2363, #2411

Changes: When the dialog is shown to the user to give permissions, the user has the option to go to app settings and grant permissions from there.

GIF of the change:

ezgif com-video-to-gif 6

@angmas1
Copy link
Contributor

angmas1 commented Jan 20, 2019

Shouldn't we make the app close on pressing OK?

@yashk2000
Copy link
Member Author

@angmas1 I've already sent a pull request for adding an exit button. When that'll be merged, there will be a separate button for the exiting the app.

@angmas1
Copy link
Contributor

angmas1 commented Jan 20, 2019

Cool, no problem.

Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ok button

@yashk2000
Copy link
Member Author

@abishekvashok should I close #2412 and update this pull request with the exit button?

@yashk2000
Copy link
Member Author

@abishekvashok I have made the changes and also added the exit button.

scrn

@abishekvashok
Copy link
Member

Can you give a gif and close the old pr?

@yashk2000
Copy link
Member Author

@abishekvashok I already have closed the old pull request.

GIF of the change:

ezgif com-video-to-gif 7

@abishekvashok abishekvashok merged commit 49bb158 into fossasia:development Jan 23, 2019
@abishekvashok
Copy link
Member

Thanks

pull bot pushed a commit to sahilsaha7773/phimpme-android that referenced this pull request Jul 18, 2019
…p settings. (fossasia#2428)

Fix for issue fossasia#2363: Option added for user to give permissions from app settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants