Skip to content

Conversation

@codedsun
Copy link
Contributor

Fixes #8378

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #8379 (a10b12f) into development (1d25fb2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a10b12f differs from pull request most recent head b119c84. Consider uploading reports for the commit b119c84 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8379      +/-   ##
===============================================
- Coverage        65.62%   65.61%   -0.01%     
===============================================
  Files              306      306              
  Lines            15929    15931       +2     
===============================================
  Hits             10453    10453              
- Misses            5476     5478       +2     
Impacted Files Coverage Δ
app/api/video_recordings.py 45.71% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d25fb2...b119c84. Read the comment docs.

@codedsun
Copy link
Contributor Author

@pc-beast @progmatic-99 Now review please. This function should only work when the provider is bbb.

@codedsun
Copy link
Contributor Author

@pc-beast @progmatic-99 Please test!

@codedsun codedsun requested a review from pavnesh-c November 15, 2021 06:00
@codedsun codedsun merged commit 3a1c1d0 into fossasia:development Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organizer video tab shows errors if there are video rooms not using BBB

4 participants