-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add search feature in schedule page #5823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nxtthmigh |
Codecov Report
@@ Coverage Diff @@
## development #5823 +/- ##
===============================================
- Coverage 23.42% 23.41% -0.02%
===============================================
Files 511 511
Lines 5468 5471 +3
Branches 65 65
===============================================
Hits 1281 1281
- Misses 4170 4173 +3
Partials 17 17
Continue to review full report at Codecov.
|
Results of speakers are not showing up as expected, e.g. type in "Andrew". The session of Andrew Aitken should show up here: https://open-event-frontend-git-searchfeature.eventyay.now.sh/e/3dbaaa50/schedule?search=Andrew |
Please add debounce to the query. The search should only happen after 250ms of user finishing the typing |
For not reloading the page, we'll have to reimplement something like #4882 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page is moving to session heading when the search result appears. The page should not move.
@mariobehling That is another issue not introduced in this PR. The issue is raised separately here #5826 Shouldn't it be handled in another PR? |
@mariobehling Ping |
#5826 has been fixed in another PR, hence merging |
Fixes #5822
Checklist
development
branch.