Skip to content

feat: add search feature in schedule page #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 3, 2020
Merged

feat: add search feature in schedule page #5823

merged 7 commits into from
Dec 3, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5822

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nxtthmigh
✅ Preview: https://open-event-frontend-git-searchfeature.eventyay.vercel.app

@maze-runnar maze-runnar changed the title Searchfeature feat: adding search feature in schedule page Nov 29, 2020
@auto-label auto-label bot added the feature label Nov 29, 2020
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #5823 (1d198b6) into development (11b6b36) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5823      +/-   ##
===============================================
- Coverage        23.42%   23.41%   -0.02%     
===============================================
  Files              511      511              
  Lines             5468     5471       +3     
  Branches            65       65              
===============================================
  Hits              1281     1281              
- Misses            4170     4173       +3     
  Partials            17       17              
Impacted Files Coverage Δ
app/controllers/public/sessions.js 0.00% <0.00%> (ø)
app/routes/public/sessions.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b6b36...1d198b6. Read the comment docs.

@mariobehling
Copy link
Member

Thank you. This position is also good.

Please fix the following:

  1. When a user enters a search phrase the page jumps to the top. It should just stay where it is.
  2. Add some spacing between buttons. They should not be directly connected.
    Screenshot from 2020-11-29 12-55-26

@mariobehling
Copy link
Member

Results of speakers are not showing up as expected, e.g. type in "Andrew". The session of Andrew Aitken should show up here: https://open-event-frontend-git-searchfeature.eventyay.now.sh/e/3dbaaa50/schedule?search=Andrew

@iamareebjamal
Copy link
Member

Please add debounce to the query. The search should only happen after 250ms of user finishing the typing

@iamareebjamal
Copy link
Member

For not reloading the page, we'll have to reimplement something like #4882

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page is moving to session heading when the search result appears. The page should not move.

@iamareebjamal
Copy link
Member

@mariobehling That is another issue not introduced in this PR. The issue is raised separately here #5826

Shouldn't it be handled in another PR?

@iamareebjamal
Copy link
Member

@mariobehling Ping

@iamareebjamal
Copy link
Member

#5826 has been fixed in another PR, hence merging

@iamareebjamal iamareebjamal changed the title feat: adding search feature in schedule page feat: add search feature in schedule page Dec 3, 2020
@iamareebjamal iamareebjamal merged commit cfc845f into fossasia:development Dec 3, 2020
@maze-runnar maze-runnar deleted the searchfeature branch December 3, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Schedule: Implement search feature
3 participants