-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Expand area below footer #5745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Expand area below footer #5745
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/19mjnc788 |
@iamareebjamal this is ready for review. |
Codecov Report
@@ Coverage Diff @@
## development #5745 +/- ##
============================================
Coverage 23.57% 23.57%
============================================
Files 510 510
Lines 5430 5430
Branches 59 59
============================================
Hits 1280 1280
Misses 4134 4134
Partials 16 16 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are y spamming you make 3 pr for same issue
2 is closed one is open
i am busy because i have exams and clasess so plz wait
I already fixed the bug #5706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate of #5706
@Raunaksingh100 see we need to fix the issue and now you have copied the solution. I can understand what you are saying but this is not cool. |
This solution already tell me by @iamareebjamal |
But you were not able to see why it was not able to solve the problem. |
If there is pr on issue so plz wait do not spam. And other person fixed that issues ""This is open source not McDonald's so plz wait""" No problems your are doing great job !!! |
@Raunaksingh100 Your solution didn't work. I commented, you didn't follow up |
Hey buddy the way of talking is not cool, we are here to make a good community and expand it, not to fight. |
@daretobedifferent18 Please don't create multiple PRs for the same issue. You can force push on the same branch |
Ok @iamareebjamal , as I said, everytime I make a PR there was the same problem, so now I have re cloned it and its going good now. Will be taking care of that in future. |
I already fixed the issue which 💯 works so, can you tell me what is the purpose of writing the i am working on this issue if some gets solutions can make pr on any issue it means we are wasting out time |
I am having difficulties following the discussion and understanding who did what when. Please return to technical discussions in this meeting and join the weekly technical meeting by @iamareebjamal to align on working according to best practices and resolving any questions. @iamareebjamal Please send a calendar invite to the contributors active in this issue as well. Thank you! Please keep up the good spirit everyone! |
@Raunaksingh100 Check my comments here #5706 (comment) Your PR wasn't working 3 days ago. It's not working even today, after you added new commits based on this PR. I commented 3 days ago, you neither replied, nor followed up to fix the PR. Please join the technical meeting tomorrow 7 PM to understand the best practices and PR review criterias. Thank You |
Fixes #5705
Short Description
Expanded Footer to make scrolling down and accessing the language switcher more comfortable.
ScreenShot
Checklist
development
branch.