Skip to content

fix: Expand area below footer #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 25, 2020
Merged

fix: Expand area below footer #5745

merged 10 commits into from
Nov 25, 2020

Conversation

divyamtayal
Copy link
Member

@divyamtayal divyamtayal commented Nov 24, 2020

Fixes #5705

Short Description

Expanded Footer to make scrolling down and accessing the language switcher more comfortable.

ScreenShot

Screenshot from 2020-11-25 02-51-53

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/19mjnc788
✅ Preview: https://open-event-frontend-git-expand-footer-5705.eventyay.vercel.app

daretobedifferent18 added 2 commits November 25, 2020 02:41
@divyamtayal
Copy link
Member Author

@iamareebjamal this is ready for review.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5745 (61d4a2c) into development (a25c9a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5745   +/-   ##
============================================
  Coverage        23.57%   23.57%           
============================================
  Files              510      510           
  Lines             5430     5430           
  Branches            59       59           
============================================
  Hits              1280     1280           
  Misses            4134     4134           
  Partials            16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25c9a2...61d4a2c. Read the comment docs.

daretobedifferent18 added 2 commits November 25, 2020 02:49
@divyamtayal
Copy link
Member Author

Screenshot from 2020-11-25 02-51-53

Copy link
Member

@Raunaksingh100 Raunaksingh100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are y spamming you make 3 pr for same issue
2 is closed one is open
now
i am busy because i have exams and clasess so plz wait

I already fixed the bug #5706

Copy link

@cggvuhh cggvuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate of #5706

@divyamtayal
Copy link
Member Author

Why are y spamming you make 3 pr for same issue
2 is closed one is open
now
i am busy because i have exams and clasess so plz wait

I already fixed the bug #5706

@Raunaksingh100 see we need to fix the issue and now you have copied the solution. I can understand what you are saying but this is not cool.
It was 3 days and no solution was there up.
And talking about creating two mnay prs , there was a problem in my system which is resolved now.

@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Nov 25, 2020

Why are y spamming you make 3 pr for same issue
2 is closed one is open
now
i am busy because i have exams and clasess so plz wait

I already fixed the bug #5706

@Raunaksingh100 see we need to fix the issue and now you have copied the solution. I can understand what you are saying but this is not cool.
It was 3 days and no solution was there up.
And talking about creating two mnay prs , there was a problem in my system which is resolved now.

This solution already tell me by @iamareebjamal
See in my pr

@divyamtayal
Copy link
Member Author

Why are y spamming you make 3 pr for same issue
2 is closed one is open
now
i am busy because i have exams and clasess so plz wait
I already fixed the bug #5706

@Raunaksingh100 see we need to fix the issue and now you have copied the solution. I can understand what you are saying but this is not cool.
It was 3 days and no solution was there up.
And talking about creating two mnay prs , there was a problem in my system which is resolved now.

This solution already tell me by @iamareebjamal
See in my pr

But you were not able to see why it was not able to solve the problem.

@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Nov 25, 2020

If there is pr on issue so plz wait do not spam.
Example -
If your are working on any issues due to some reason your not active for 2 days

And other person fixed that issues
And make so many pr. This is not so good

""This is open source not McDonald's so plz wait"""

No problems your are doing great job !!!

@iamareebjamal
Copy link
Member

@Raunaksingh100 Your solution didn't work. I commented, you didn't follow up

@divyamtayal
Copy link
Member Author

If there is pr on issue so plz wait do not spam.
Example -
If your are working on any issues due to some reason your not active for 2 days

And other person fixed that issues
And make so many pr. This is not so good

""This is open source not McDonald's so plz wait"""

Hey buddy the way of talking is not cool, we are here to make a good community and expand it, not to fight.
If you think I am taking your contribution, sorry that's not the case.

@iamareebjamal
Copy link
Member

@daretobedifferent18 Please don't create multiple PRs for the same issue. You can force push on the same branch

@divyamtayal
Copy link
Member Author

@daretobedifferent18 Please don't create multiple PRs for the same issue. You can force push on the same branch

Ok @iamareebjamal , as I said, everytime I make a PR there was the same problem, so now I have re cloned it and its going good now. Will be taking care of that in future.

@Raunaksingh100
Copy link
Member

Raunaksingh100 commented Nov 25, 2020

I already fixed the issue which 💯 works
but @daretobedifferent18 but you also fixed the issue
And your pr gets merged.

so, can you tell me what is the purpose of writing the i am working on this issue if some gets solutions can make pr on any issue it means we are wasting out time

@mariobehling
Copy link
Member

I am having difficulties following the discussion and understanding who did what when. Please return to technical discussions in this meeting and join the weekly technical meeting by @iamareebjamal to align on working according to best practices and resolving any questions.

@iamareebjamal Please send a calendar invite to the contributors active in this issue as well. Thank you!

Please keep up the good spirit everyone!

@iamareebjamal iamareebjamal changed the title Expand Footer fix: Expand area below footer Nov 25, 2020
@auto-label auto-label bot added the fix label Nov 25, 2020
@iamareebjamal
Copy link
Member

iamareebjamal commented Nov 25, 2020

@Raunaksingh100 Check my comments here #5706 (comment)

Your PR wasn't working 3 days ago. It's not working even today, after you added new commits based on this PR. I commented 3 days ago, you neither replied, nor followed up to fix the PR. Please join the technical meeting tomorrow 7 PM to understand the best practices and PR review criterias. Thank You

@iamareebjamal iamareebjamal merged commit 4006f52 into fossasia:development Nov 25, 2020
@divyamtayal divyamtayal deleted the expand-footer-5705 branch November 27, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer: Expand area below last footer line
6 participants