fix: footer Expand area below last footer line #5706

Raunaksingh100 · 2020-11-21T06:51:32Z

Short description of what this resolves:

footer Expand area below last footer line

screenshot

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-11-21T06:51:38Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ffxdoqqpd
✅ Preview: https://open-event-frontend-git-patch-6.eventyay.now.sh

Raunaksingh100 · 2020-11-21T06:52:33Z

@mariobehling and @iamareebjamal can you review this pr

iamareebjamal · 2020-11-21T07:03:13Z

app/styles/components/extras.scss

@@ -14,3 +14,7 @@ a.link-item {
 .leaflet-container {
  height: 300px;
 }
+
+div#ember126 {


I just merged a PR and this changed to ember234. Tomorrow it might be 132, the next day it'll be 342. We don't want to merge a PR to fix this every day. We want a solution which works once and for all

i will fixed it

iamareebjamal · 2020-11-21T07:04:57Z

@Raunaksingh100 Thankfully GitHub has a notification system, we know when someone creates a PR, you don't need to comment for us to know. This is probably 5th time I had to tell you this. No, thanks, we don't need comments to know that you have created a PR

codecov · 2020-11-21T07:23:37Z

Codecov Report

Merging #5706 (898a765) into development (975272a) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #5706      +/-   ##
===============================================
- Coverage        23.62%   23.57%   -0.06%     
===============================================
  Files              510      510              
  Lines             5417     5430      +13     
  Branches            59       59              
===============================================
  Hits              1280     1280              
- Misses            4122     4134      +12     
- Partials            15       16       +1

Impacted Files	Coverage Δ
app/components/widgets/forms/social-link-field.ts	`60.00% <0.00%> (-15.00%)`	⬇️
app/services/cache.ts	`64.15% <0.00%> (-5.67%)`	⬇️
app/routes/index.js	`78.57% <0.00%> (ø)`
app/components/public/side-menu.js	`0.00% <0.00%> (ø)`
app/controllers/admin/events/list.js	`0.00% <0.00%> (ø)`
app/components/forms/orders/attendee-list.js	`0.00% <0.00%> (ø)`
app/controllers/events/view/tickets/orders/list.js	`0.00% <0.00%> (ø)`
.../components/forms/wizard/sessions-speakers-step.js	`0.00% <0.00%> (ø)`
app/mixins/ember-table-route.js	`80.00% <0.00%> (+5.00%)`	⬆️
app/controllers/events/list.js	`23.07% <0.00%> (+13.98%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975272a...fdd9559. Read the comment docs.

iamareebjamal · 2020-11-21T07:36:10Z

app/styles/components/extras.scss

@@ -14,3 +14,7 @@ a.link-item {
 .leaflet-container {
  height: 300px;
 }
+
+.floating.labeled.grey.search.icon.mini.button.ui.dropdown.ember-view.upward.active.visible {


Tomorrow I will change one class on the element and it'll stop working

Tomorrow I will change one class on the element and it'll stop working

i am doing the wrong things the purpose of the issue is ""footer Expand area below last footer line""
i will fixed

mariobehling · 2020-11-21T14:24:39Z

You need to implement the change below the absolute last line. Do not change anything in between the footer. Add space on the very end.

divyamtayal · 2020-11-22T03:37:52Z

app/templates/components/footer-main.hbs

@@ -102,6 +102,7 @@
      </div>
    </div>
    <div class="ui inverted section divider"></div>
+    <br>


Don't do it like this

Can you little guide ma what is the purpose of the issue I am little confused

we need to add/expand the space after the last line, use inline styling.

i updated the code

iamareebjamal · 2020-11-22T08:22:38Z

app/templates/components/footer-main.hbs

@@ -101,7 +101,7 @@
        </div>
      </div>
    </div>
-    <div class="ui inverted section divider"></div>
+    <div class="ui inverted section divider"style="margin-bottom: 40px!important;"></div>


mb-4

I added the code can you review

It's not working AFAIK

already update the code but,

@iamareebjamal can you tell me what is the purpose of writing the i am working on this issue if some gets solutions can make pr on any issue it means we are wasting out time

Can you tell me what's the purpose of reviewing PRs and writing "It's not working AFAIK" and not getting any follow up on that?

Raunaksingh100 · 2020-11-25T07:43:24Z

@mariobehling i fixed the bug can you review

iamareebjamal · 2020-11-25T09:19:28Z

@Raunaksingh100 This is your last commit 3 days ago 6044ccc (#5706)

Which was not working. I commented that it is not working. You did not follow up. Revert to this commit, and show me that it is working. I'll merge this PR, otherwise I'll merge #5745

You can't just stay silent on follow up and then complain that your non-working PR was not merged and then copy the solution from a working PR 3 days later. Why did you not follow up on my comment for 3 days?

If you had the solution, why did you not fix the PR 3 days ago, why just now after someone else submitted a working PR?

iamareebjamal · 2020-11-25T09:24:53Z

#5706

Your PR:

How can you possibly expect me to merge a PR which not only does not fix the issue, but also breaks the existing UI?

iamareebjamal · 2020-11-25T09:30:58Z

I'm sorry, your work was based on the new PR which was created by @daretobedifferent18
Please follow up when asked for review. You can't expect no one to solve a basic issue if you don't reply or follow up on a PR for days. We want to optimize for issues being solved. Not replying or following up is a blocker and ties up the hands of other people who may fix the issue.

fix; Footer: Expand area below last footer line

c2b2717

vercel bot deployed to Preview November 21, 2020 06:51 View deployment

iamareebjamal reviewed Nov 21, 2020

View reviewed changes

fix: Footer Expand area below last footer line

e45cdae

vercel bot deployed to Preview November 21, 2020 07:10 View deployment

iamareebjamal reviewed Nov 21, 2020

View reviewed changes

fix: Footer Expand area below last footer line

29906ac

vercel bot deployed to Preview November 21, 2020 10:21 View deployment

Raunaksingh100 changed the title ~~fix; Footer: Expand area below last footer line~~ fix: footer Expand area below last footer line Nov 21, 2020

auto-label bot added the fix label Nov 21, 2020

fix: footer Expand area below last footer line

7b72a76

vercel bot deployed to Preview November 21, 2020 10:25 View deployment

divyamtayal reviewed Nov 22, 2020

View reviewed changes

fix: footer Expand area below last footer line

3d192bd

vercel bot deployed to Preview November 22, 2020 07:25 View deployment

fix: footer Expand area below last footer line

115d9dd

vercel bot deployed to Preview November 22, 2020 07:35 View deployment

fix: footer Expand area below last footer line

46b220e

vercel bot deployed to Preview November 22, 2020 07:42 View deployment

iamareebjamal reviewed Nov 22, 2020

View reviewed changes

fix: footer Expand area below last footer line

6044ccc

vercel bot deployed to Preview November 22, 2020 09:30 View deployment

fix: footer Expand area below last footer line

29cdc74

vercel bot deployed to Preview November 25, 2020 07:37 View deployment

fix: footer Expand area below last footer line

ae476a5

vercel bot deployed to Preview November 25, 2020 07:42 View deployment

cggvuhh previously approved these changes Nov 25, 2020

View reviewed changes

divyamtayal mentioned this pull request Nov 25, 2020

fix: Expand area below footer #5745

Merged

5 tasks

fix: footer Expand area below last footer line

898a765

Raunaksingh100 dismissed cggvuhh’s stale review via 898a765 November 25, 2020 08:10

vercel bot deployed to Preview November 25, 2020 08:10 View deployment

cggvuhh previously approved these changes Nov 25, 2020

View reviewed changes

fix: Expand area below footer

fdd9559

Raunaksingh100 dismissed cggvuhh’s stale review via fdd9559 November 25, 2020 09:35

vercel bot deployed to Preview November 25, 2020 09:36 View deployment

Raunaksingh100 closed this Nov 25, 2020

Raunaksingh100 deleted the patch-6 branch November 25, 2020 09:39

fix: footer Expand area below last footer line #5706

fix: footer Expand area below last footer line #5706

Uh oh!

Conversation

Raunaksingh100 commented Nov 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description of what this resolves:

screenshot

Checklist

Uh oh!

vercel bot commented Nov 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Raunaksingh100 commented Nov 21, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Nov 21, 2020

Uh oh!

codecov bot commented Nov 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Raunaksingh100 Nov 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mariobehling commented Nov 21, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Raunaksingh100 Nov 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Raunaksingh100 commented Nov 25, 2020

Uh oh!

iamareebjamal commented Nov 25, 2020

Uh oh!

iamareebjamal commented Nov 25, 2020

Uh oh!

iamareebjamal commented Nov 25, 2020

Uh oh!

Uh oh!

Raunaksingh100 commented Nov 21, 2020 •

edited

Loading

vercel bot commented Nov 21, 2020 •

edited

Loading

codecov bot commented Nov 21, 2020 •

edited

Loading

Raunaksingh100 Nov 21, 2020 •

edited

Loading

Raunaksingh100 Nov 25, 2020 •

edited

Loading