feat: Add cookie policy editor and fix hide behaviour #5073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/h1pciyapf |
Codecov Report
@@ Coverage Diff @@
## development #5073 +/- ##
===============================================
+ Coverage 22.68% 22.76% +0.07%
===============================================
Files 488 489 +1
Lines 5183 5162 -21
Branches 21 28 +7
===============================================
- Hits 1176 1175 -1
+ Misses 4003 3983 -20
Partials 4 4
Continue to review full report at Codecov.
|
| @@ -2,7 +2,7 @@ | |||
| <div id='device-type-identifier'></div> | |||
| {{#if this.showCookie}} | |||
| <div class="ui inline warning large message"> | |||
| <i class="close icon" onclick={{action (mut this.showCookie) false}} role="button"></i> | |||
| <i class="close icon" onclick={{action 'hideCookieMessage'}} role="button"></i> | |||
| {{this.model.cookiePolicy}} | |||
| {{#if this.model.cookiePolicyLink}} | |||
| <p><a href="{{this.model.cookiePolicyLink}}">Click here For more information</a></p> | |||
There was a problem hiding this comment.
Please change to "Click here for more information."
(no capital F in For)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5071
Fixes #5028
Cookie Policy and Link can now be edited in Admin Settings