Skip to content

fix: Link and show session detail to guests #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 15, 2020

Fixes #5055
Fixes #5052

@vercel
Copy link

vercel bot commented Sep 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3kl2ahsb9
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-session-detail.eventyay.vercel.app

@auto-label auto-label bot added the fix label Sep 15, 2020
mariobehling
mariobehling previously approved these changes Sep 15, 2020
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Only need to fix Travis tests.

Follow-up issue is here #5054

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #5070 into development will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5070      +/-   ##
===============================================
+ Coverage        22.68%   22.85%   +0.16%     
===============================================
  Files              488      489       +1     
  Lines             5183     5159      -24     
  Branches            21       28       +7     
===============================================
+ Hits              1176     1179       +3     
+ Misses            4003     3976      -27     
  Partials             4        4              
Impacted Files Coverage Δ
app/controllers/public/session/view.js 0.00% <0.00%> (ø)
app/routes/public/session/view.js 0.00% <ø> (ø)
app/components/forms/wizard/basic-details-step.js 18.98% <0.00%> (-2.54%) ⬇️
app/mixins/event-wizard.js 1.05% <0.00%> (ø)
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/components/forms/wizard/attendee-step.js 0.00% <0.00%> (ø)
app/components/forms/wizard/sponsors-step.js 0.00% <0.00%> (ø)
app/components/forms/wizard/other-details-step.js 0.00% <0.00%> (ø)
.../components/forms/wizard/sessions-speakers-step.js 0.00% <0.00%> (ø)
app/components/events/view/publish-bar.ts 17.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e991a...f97bfa1. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 2cb3539 into fossasia:development Sep 15, 2020
@iamareebjamal iamareebjamal deleted the session-detail branch September 15, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anonymous users can't see linked session in speakers page Public Schedule: Add link to specific session page
2 participants