feat: make publishing event clearer #5011

maze-runnar · 2020-09-08T07:00:16Z

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-09-08T07:00:25Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2q1p1a2bh
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-clearer.eventyay.vercel.app

maze-runnar · 2020-09-08T07:01:51Z

@iamareebjamal please review

codecov · 2020-09-08T08:57:53Z

Codecov Report

Merging #5011 into development will increase coverage by 0.16%.
The diff coverage is 14.70%.

@@               Coverage Diff               @@
##           development    #5011      +/-   ##
===============================================
+ Coverage        22.68%   22.85%   +0.16%     
===============================================
  Files              488      489       +1     
  Lines             5183     5159      -24     
  Branches            21       28       +7     
===============================================
+ Hits              1176     1179       +3     
+ Misses            4003     3976      -27     
  Partials             4        4

Impacted Files	Coverage Δ
app/components/forms/wizard/attendee-step.js	`0.00% <ø> (ø)`
app/components/forms/wizard/basic-details-step.js	`18.98% <ø> (-2.54%)`	⬇️
app/components/forms/wizard/other-details-step.js	`0.00% <ø> (ø)`
.../components/forms/wizard/sessions-speakers-step.js	`0.00% <ø> (ø)`
app/components/forms/wizard/sponsors-step.js	`0.00% <ø> (ø)`
app/controllers/events/view.js	`0.00% <ø> (ø)`
app/mixins/event-wizard.js	`1.05% <0.00%> (ø)`
app/components/events/view/publish-bar.ts	`17.24% <17.24%> (ø)`
app/utils/computed-helpers.js	`21.27% <0.00%> (-0.47%)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3275795...d130537. Read the comment docs.

mariobehling

Please read the issue description again carefully and rename the buttons accordingly. There is no point to review your PRs if you dont read the issues.

1. When event is created and still unpublished (Draft Mode)

2. After an event is published already (Live Event)

Requirement for an event to be publishable is, that it has
1. A name
2. A location or online event link
3. A ticket
below the above savings/next/previous options show another section with two buttons
- Show the text "This event is published. Any changes you make will appear on your live event."
- View (open in new tab)
- Unpublish (opens a pop up - same as "Unpublish" on the dashboard / afterwards exits to event dashboard)

3. Top menu "Wizard Steps"

When a user clicks a top wizard menu item the following action should take place:

Cancel changes of the current tab and load the menu tab

mariobehling · 2020-09-08T10:51:42Z

Please also

increase the spacing between the the first row of buttons and the second row "View/Publish" button.
add a horizontal line of 100% page width above the second row

As you can see in the screenshot the buttons show "Preview/Unpublish". Expected is "View/Unpublish". The View button does not open in a new tab as described in the issue.

Sorry, but this seems a bit unfair - do you expect other devs to review your PRs and point out each of the list items on the issue to you one by one?

Please go through each point first by yourself and do help us to shorten the review time that is required by paying more attention to each point. Thank you.

maze-runnar · 2020-09-08T16:20:07Z

Button Spacing, open preview in new window, adding horizontal line, Showing the text "This event is published. Any changes you make will appear on your live event." and "This event is currently not published. It is in draft mode and it is not visible publicly.".

maze-runnar · 2020-09-08T16:24:23Z

Publish and unpublish popup are not working the same as in the dashboard section. So made all other changes.

mariobehling · 2020-09-08T16:41:40Z

Thank you, please also change

Rename "Forward" to -> "Next"
Live events are missing the "Save" feature (Clicking "Save" should save the current wizard step and exit to the dashboard of this event)

mariobehling · 2020-09-08T17:02:05Z

When creating a new event, it is not clear yet how to publish it.

I think it should only be possible to publish an event once the event draft has been saved.

Therefore please display:

A "Publish" button that is in grey color as long as the event has not been saved as a draft.
A horizontal line as in other views
In this initial step - before the event has been saved, please also show the following text above the horizontal line: "You can preview the event after you have saved it as a draft. You can publish the event after filling in the required fields."

maze-runnar · 2020-09-08T17:24:17Z

Live events are missing the "Save" feature (Clicking "Save" should save the current wizard step and exit to the dashboard of this event)

I am not getting it, why live events should option to save,while it can be published.

maze-runnar · 2020-09-08T17:27:25Z

I think it should only be possible to publish an event once the event draft has been saved.

Therefore please display:
A "Publish" button that is in grey color as long as the event has not been saved as a draft.

previously it was mentioned in issue like toicket, location and name is required for publishing an event. After these changes user can't publish events in first time?

maze-runnar · 2020-09-08T18:28:09Z

changing msg when event is not saved for first time, and forward -> Next

maze-runnar · 2020-09-08T18:46:16Z

make publish button grey when event is not saved for first time -

maze-runnar · 2020-09-08T18:47:43Z

Made all the required changes, not sure that save button should display when event is published.

mariobehling · 2020-09-08T18:50:59Z

Made all the required changes, not sure that save button should display when event is published.

Yes, please display a "Save" button when the event is published as well.

mariobehling · 2020-09-08T18:57:10Z

Still missing:

Show "Save" button after event is published
Publish (opens a pop up - same as "Publish" on the dashboard / afterwards exits to event dashboard).
- Show the pop up
Unpublish (opens a pop up - same as "Unpublish" on the dashboard / afterwards exits to event dashboard)
- Show the pop up

maze-runnar · 2020-09-15T03:06:44Z

now it's working correctly

iamareebjamal · 2020-09-15T05:52:18Z

app/mixins/event-wizard.js

@@ -46,6 +47,10 @@ export default Mixin.create(MutableArray, CustomFormMixin, {
    ];
  },

+  ticketsPresent: computed('data.event.tickets.@each', function() {


Why bring this back? It's not needed

Now this is back again

iamareebjamal · 2020-09-15T05:52:26Z

app/mixins/event-wizard.js

@@ -227,6 +232,44 @@ export default Mixin.create(MutableArray, CustomFormMixin, {
        callback(true);
      });
    },
+
+    openConfirmModal() {


Why bring this back? It's not needed

iamareebjamal · 2020-09-15T05:52:32Z

app/mixins/event-wizard.js

+      this.set('isPublishUnpublishModalOpen', true);
+    },
+
+    togglePublishState() {


Why bring this back? It's not needed

iamareebjamal · 2020-09-15T05:53:30Z

You have added some functions back which are not needed. Please remove them

iamareebjamal · 2020-09-15T07:35:23Z

app/mixins/event-wizard.js

    addItem(type, model) {
      if (type === 'socialLinks') {
        this.get(`data.event.${type}`).pushObject(this.store.createRecord(model, {
          identifier: v1()
        }));
-      } else if (type === 'customLink') {


Why remove this?

iamareebjamal · 2020-09-15T07:38:39Z

Um, now you removed a random if statement which was necessary. There always seems to be either some random thing added or removed. Please carefully review the changes yourself before committing. There are way more review cycles than needed. You need to improve the self-evaluation phase of your PRs

iamareebjamal · 2020-09-15T07:58:27Z

Now ticketsPresent is back again. Please review the changes locally before committing and then before pushing

maze-runnar · 2020-09-15T07:58:56Z

Um, now you removed a random if statement which was necessary. There always seems to be either some random think added or removed.

yeah, I don't know why this happens to me a lot, and in this PR more than a lot. I am trying to improve it.

iamareebjamal · 2020-09-15T08:01:26Z

Before pushing. Go through the code where you made the changes and check all the things previously mentioned are removed or not, and nothing else is removed. If you're trying to do it using GitHub UI, then it definitely won't be correct because it is extremely easy to make mistakes there and not realize what you are removing and what extra thing you removed. Nor is there any way to review the final changes before pushing

niranjan94 · 2020-09-15T08:26:38Z

Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ app/controllers/events/view.js  -4

See the complete overview on Codacy

maze-runnar · 2020-09-15T08:50:37Z

I think it's ok now.

mariobehling · 2020-09-15T10:18:57Z

Glad, it is working now! Thank you.

making publishing event clearer

2401a1f

auto-label bot added the fix label Sep 8, 2020

vercel bot deployed to Preview September 8, 2020 07:00 View deployment

maze-runnar mentioned this pull request Sep 8, 2020

feat: Make Event Saving, Draft Mode, Publishing Clearer #4942

Closed

5 tasks

-

5a73500

mariobehling requested changes Sep 8, 2020

View reviewed changes

button look, spacing and other

04e41b3

vercel bot deployed to Preview September 8, 2020 16:05 View deployment

open preview in new tab, just do it

9479d17

vercel bot deployed to Preview September 8, 2020 16:16 View deployment

forward to next, proper msg when event no saved

10f6406

vercel bot deployed to Preview September 8, 2020 18:26 View deployment

make publish button grey when event is not saved

ed2b061

vercel bot deployed to Preview September 8, 2020 18:45 View deployment

show Save button always

685c9f6

maze-runnar added 2 commits September 15, 2020 07:27

rebasing..

e3a8e66

moving out of form tag

36fe0ff

vercel bot deployed to Preview September 15, 2020 03:05 View deployment

iamareebjamal reviewed Sep 15, 2020

View reviewed changes

vercel bot deployed to Preview September 15, 2020 07:11 View deployment

iamareebjamal reviewed Sep 15, 2020

View reviewed changes

i don't know why i am not doing it correctly

cce88f8

vercel bot deployed to Preview September 15, 2020 07:47 View deployment

removing computed import

d130537

vercel bot deployed to Preview September 15, 2020 08:24 View deployment

iamareebjamal approved these changes Sep 15, 2020

View reviewed changes

iamareebjamal removed the DO-NOT-MERGE label Sep 15, 2020

iamareebjamal approved these changes Sep 15, 2020

View reviewed changes

iamareebjamal changed the title ~~fix: making publishing event clearer~~ fix: make publishing event clearer Sep 15, 2020

iamareebjamal changed the title ~~fix: make publishing event clearer~~ feat: make publishing event clearer Sep 15, 2020

auto-label bot added feature and removed fix labels Sep 15, 2020

iamareebjamal merged commit e28bfe6 into fossasia:development Sep 15, 2020

maze-runnar deleted the clearer branch December 13, 2020 03:54

feat: make publishing event clearer #5011

feat: make publishing event clearer #5011

Uh oh!

Conversation

maze-runnar commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

vercel bot commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

codecov bot commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mariobehling left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mariobehling commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maze-runnar commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maze-runnar commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mariobehling commented Sep 8, 2020

Uh oh!

mariobehling commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mariobehling commented Sep 8, 2020

Uh oh!

mariobehling commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maze-runnar commented Sep 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamareebjamal Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Sep 15, 2020

Uh oh!

iamareebjamal Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Sep 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamareebjamal commented Sep 15, 2020

Uh oh!

maze-runnar commented Sep 15, 2020

Uh oh!

iamareebjamal commented Sep 15, 2020

Uh oh!

niranjan94 commented Sep 15, 2020

maze-runnar commented Sep 8, 2020 •

edited

Loading

vercel bot commented Sep 8, 2020 •

edited

Loading

codecov bot commented Sep 8, 2020 •

edited

Loading

mariobehling left a comment •

edited

Loading

mariobehling commented Sep 8, 2020 •

edited

Loading

maze-runnar commented Sep 8, 2020 •

edited

Loading

maze-runnar commented Sep 8, 2020 •

edited

Loading

maze-runnar commented Sep 8, 2020 •

edited

Loading

mariobehling commented Sep 8, 2020 •

edited

Loading

maze-runnar commented Sep 15, 2020 •

edited

Loading

iamareebjamal commented Sep 15, 2020 •

edited

Loading