feat: Make Event Saving, Draft Mode, Publishing Clearer #4942

maze-runnar · 2020-09-02T14:29:53Z

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

vercel · 2020-09-02T14:30:02Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/655ziwvf5
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-2.eventyay.vercel.app

maze-runnar · 2020-09-02T14:30:49Z

@iamareebjamal I have currently made changes for only first step wizard, if these changes are ok then I will proceed.

mariobehling · 2020-09-02T16:03:43Z

Thanks!

For consistency please keep Publish/View/Preview buttons in the same order, shape, spacing as on event dashboard.

Compare e.g.

codecov · 2020-09-02T17:20:01Z

Codecov Report

Merging #4942 into development will decrease coverage by 0.00%.
The diff coverage is 8.69%.

@@               Coverage Diff               @@
##           development    #4942      +/-   ##
===============================================
- Coverage        22.82%   22.82%   -0.01%     
===============================================
  Files              485      485              
  Lines             5148     5170      +22     
  Branches            21       21              
===============================================
+ Hits              1175     1180       +5     
- Misses            3969     3986      +17     
  Partials             4        4

Impacted Files	Coverage Δ
app/components/forms/wizard/attendee-step.js	`0.00% <0.00%> (ø)`
app/components/forms/wizard/other-details-step.js	`0.00% <0.00%> (ø)`
.../components/forms/wizard/sessions-speakers-step.js	`0.00% <0.00%> (ø)`
app/components/forms/wizard/sponsors-step.js	`0.00% <0.00%> (ø)`
app/mixins/event-wizard.js	`1.08% <0.00%> (-0.05%)`	⬇️
app/components/forms/wizard/basic-details-step.js	`20.83% <100.00%> (+2.26%)`	⬆️
app/components/tabbed-navigation.js	`53.33% <0.00%> (+20.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112b8b3...7c75a5e. Read the comment docs.

maze-runnar · 2020-09-02T17:23:17Z

adding preiew url on this page is giving error and blocking from publishing events.

maze-runnar · 2020-09-02T17:26:38Z

maze-runnar · 2020-09-02T17:41:12Z

adding cancel button without creating an event is not working, it can be added from the second wizard step or when user is not editing event first time.

maze-runnar · 2020-09-02T17:45:49Z

@iamareebjamal I need help with this issue, like what should be the approach, is my approach right or any other efficient way?
and also

adding cancel button without creating an event is not working, it can be added from the second wizard step or when user is not editing event first time.

maze-runnar · 2020-09-02T17:50:49Z

we can add a cancel and preview button once event is saved or published, but no way to know that event is saved at least once. can I add these buttons when event.state == "published"

mariobehling · 2020-09-02T21:46:06Z

@iamareebjamal I need help with this issue, like what should be the approach, is my approach right or any other efficient way?
and also

adding cancel button without creating an event is not working, it can be added from the second wizard step or when user is not editing event first time.

Yes, that is expected. This is why the option in this case should be a "Discard" button. Eventbrite handles this in the same way. As long as an event is not "Saved as Draft" there can be no preview and it cannot be cancelled. Any information can only be discarded as long as the event is not saved.

iamareebjamal · 2020-09-02T23:53:41Z

Like I mentioned in the issue, event.id is null for unsaved events

maze-runnar · 2020-09-03T03:20:46Z

it's working now, thanks @iamareebjamal

maze-runnar · 2020-09-03T03:23:56Z

Do i need to ad this in every wizard step, or it will be only in first step?

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>

lgtm-com · 2020-09-03T06:29:59Z

This pull request introduces 1 alert when merging 3dfe4d2 into 112b8b3 - view on LGTM.com

new alerts:

1 for Syntax error

iamareebjamal · 2020-09-03T15:28:10Z

@maze-runnar Update?

lgtm-com · 2020-09-03T15:58:17Z

This pull request introduces 1 alert when merging a218fda into 323c503 - view on LGTM.com

new alerts:

1 for Syntax error

iamareebjamal · 2020-09-03T16:05:00Z

app/components/forms/wizard/other-details-step.js

@@ -39,6 +39,10 @@ export default Component.extend(FormMixin, EventWizardMixin, {
    return !!this.data.event.codeOfConduct;
  }),

+  ticketsPresent: computed('data.event.tickets.@each', function() {
+    return this.data.event.tickets.length > 0;
+  }),


This is present in all 3 components

where i should put it?

can I put it in event-wizard in mixins? Will it work from there for all these components?

iamareebjamal · 2020-09-08T04:38:42Z

@maze-runnar Your repo is deleted. I can't pull in changes to test

maze-runnar · 2020-09-08T05:10:16Z

@maze-runnar Your repo is deleted. I can't pull in changes to test

can't it be tested on deployment URL please, or I have to create a new PR.

iamareebjamal · 2020-09-08T05:16:00Z

I have to make changes and I can't do that unless I pull te changes

maze-runnar · 2020-09-08T05:19:23Z

I have to make changes and I can't do that unless I pull te changes

ok so I will create a new PR.

maze-runnar · 2020-09-08T07:02:33Z

go to #5011

maze-runnar added 3 commits September 2, 2020 19:53

Update basic-details-step.hbs

aeed858

Update basic-details-step.js

829ab7c

Update event-wizard.js

6f8af2c

vercel bot deployed to Preview September 2, 2020 14:29 View deployment

maze-runnar changed the title ~~enh: Make Event Saving, Draft Mode, Publishing Clearer~~ WIP: Make Event Saving, Draft Mode, Publishing Clearer Sep 2, 2020

removing preview and view buttons, restrcting ublishing a new event

76a7bea

vercel bot deployed to Preview September 2, 2020 17:04 View deployment

adding cancel button

808af51

vercel bot deployed to Preview September 2, 2020 17:27 View deployment

reverting cancel button

41f72f0

vercel bot deployed to Preview September 2, 2020 17:37 View deployment

adding check for event is for first-time or not

7f51bcb

vercel bot temporarily deployed to Preview September 3, 2020 03:16 Inactive

adding computed function firstTimeEvent

dbe6946

vercel bot deployed to Preview September 3, 2020 03:18 View deployment

maze-runnar changed the title ~~WIP: Make Event Saving, Draft Mode, Publishing Clearer~~ feat: Make Event Saving, Draft Mode, Publishing Clearer Sep 3, 2020

auto-label bot added the feature label Sep 3, 2020

Update sessions-speakers-step.hbs

39d4548

vercel bot temporarily deployed to Preview September 3, 2020 06:21 Inactive

Update sponsors-step.hbs

c656327

vercel bot temporarily deployed to Preview September 3, 2020 06:22 Inactive

Update app/templates/components/forms/wizard/basic-details-step.hbs

3dfe4d2

Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>

vercel bot had a problem deploying to Preview September 3, 2020 06:23 Failure

iamareebjamal mentioned this pull request Sep 3, 2020

Event Type,Event Topic,Event subtopic, License cannot be made null once set #2302

Closed

fixing syntax error

f997d31

vercel bot temporarily deployed to Preview September 3, 2020 15:49 Inactive

fixing codacy

e13a785

vercel bot temporarily deployed to Preview September 3, 2020 15:50 Inactive

fixing codacy

a218fda

vercel bot had a problem deploying to Preview September 3, 2020 15:53 Failure

fixing an unusual syntax error

243f56a

vercel bot had a problem deploying to Preview September 3, 2020 16:03 Failure

iamareebjamal reviewed Sep 3, 2020

View reviewed changes

comma

7bf19fc

vercel bot deployed to Preview September 3, 2020 16:07 View deployment

trailing space fix

7c75a5e

vercel bot deployed to Preview September 3, 2020 16:17 View deployment

maze-runnar mentioned this pull request Sep 8, 2020

feat: make publishing event clearer #5011

Merged

5 tasks

maze-runnar closed this Sep 8, 2020

feat: Make Event Saving, Draft Mode, Publishing Clearer #4942

feat: Make Event Saving, Draft Mode, Publishing Clearer #4942

Uh oh!

Conversation

maze-runnar commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

vercel bot commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maze-runnar commented Sep 2, 2020

Uh oh!

mariobehling commented Sep 2, 2020

Uh oh!

codecov bot commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

maze-runnar commented Sep 2, 2020

Uh oh!

maze-runnar commented Sep 2, 2020

Uh oh!

maze-runnar commented Sep 2, 2020

Uh oh!

maze-runnar commented Sep 2, 2020

Uh oh!

maze-runnar commented Sep 2, 2020

Uh oh!

mariobehling commented Sep 2, 2020

Uh oh!

iamareebjamal commented Sep 2, 2020

Uh oh!

maze-runnar commented Sep 3, 2020

Uh oh!

maze-runnar commented Sep 3, 2020

Uh oh!

lgtm-com bot commented Sep 3, 2020

Uh oh!

iamareebjamal commented Sep 3, 2020

Uh oh!

lgtm-com bot commented Sep 3, 2020

Uh oh!

iamareebjamal Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

maze-runnar Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

maze-runnar Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

iamareebjamal commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

maze-runnar commented Sep 8, 2020

Uh oh!

Uh oh!

maze-runnar commented Sep 2, 2020 •

edited

Loading

vercel bot commented Sep 2, 2020 •

edited

Loading

codecov bot commented Sep 2, 2020 •

edited

Loading

maze-runnar Sep 3, 2020 •

edited

Loading