Skip to content

feat: change session to schedule & schedule to calendar in URL #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2020
Merged

feat: change session to schedule & schedule to calendar in URL #4918

merged 2 commits into from
Aug 31, 2020

Conversation

maze-runnar
Copy link
Contributor

@maze-runnar maze-runnar commented Aug 31, 2020

Fixes #4920

Screenshot from 2020-08-31 14-43-37
Screenshot from 2020-08-31 14-43-30

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5yegt7ctb
✅ Preview: https://open-event-frontend-git-fork-maze-runnar-patch-7.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #4918 into development will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4918   +/-   ##
============================================
  Coverage        23.16%   23.16%           
============================================
  Files              481      481           
  Lines             5098     5098           
  Branches            18       18           
============================================
  Hits              1181     1181           
  Misses            3913     3913           
  Partials             4        4           
Impacted Files Coverage Δ
app/router.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9663982...148eb7d. Read the comment docs.

@iamareebjamal iamareebjamal changed the title enh: changing session to schedule & schedule to calendar in URL feat: change session to schedule & schedule to calendar in URL Aug 31, 2020
@auto-label auto-label bot added the feature label Aug 31, 2020
@iamareebjamal iamareebjamal merged commit a93c224 into fossasia:development Aug 31, 2020
@maze-runnar maze-runnar deleted the patch-7 branch August 31, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change sessions and schedule URL structure
2 participants