-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Add tracks and rooms filters on sessions page #4879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/oish4hinp |
@iamareebjamal this code in routes/sessions.js is not working for filtering -
|
Codecov Report
@@ Coverage Diff @@
## development #4879 +/- ##
===============================================
- Coverage 23.19% 23.17% -0.02%
===============================================
Files 481 481
Lines 5092 5096 +4
Branches 18 18
===============================================
Hits 1181 1181
- Misses 3907 3911 +4
Partials 4 4
Continue to review full report at Codecov.
|
Checking |
Filter for track should look like this:
|
So, if (params.track) {
filterOptions.push({
name : 'track',
op : 'has',
val : {
name: 'name',
op: 'eq',
val: params.track
}
})
} |
Please also use the colors in the sidebar for the tracks, if possible. |
I see whenever we change a filter or date the page goes up to the top of the page. How can we go to the top of the event page heading instead, e.g. here the heading "Sessions"? |
@maze-runnar Please make the UI as close to the generator UI, with colors for tracks. Also, the chosen track/room should be highlighted and a |
@mariobehling A page reload is done when a filter is applied. To control the scroll of the page, we'll have to reimplement a lot of things in the route, so I'll create a separate issue to handle this in future |
@iamareebjamal is it ok? |
Color the circle, not the text. And the minus sign should be single (not against every track) and on the right of the text |
@iamareebjamal please review - |
|
@iamareebjamal please take a look at requirements by @mariobehling. And please tell me final changes I have to make |
@maze-runnar I think we are all aligned in understanding that we want to make it as similar as possible to the website generator. The question is just how far can we get in this iteration. Would be great, if you make the last changes mentioned by both of us and then we can also try and see how it works on the live site. |
To clear the room filters
|
Please change filter text font from blue to standard dark color. I think it is black or dark gray. |
I'm polishing it @maze-runnar, please take up the grouping issue |
@mariobehling I tried a lot to implement clear filters without the minus icon but it doesn't work for some reason. Going for this for now, will revisit another time |
Fixes #4852
Checklist
development
branch.