Skip to content

fix: Empty session added on toggling add session #4581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 20, 2020

Fixes #4575

@vercel
Copy link

vercel bot commented Jul 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lgjguw6ro
✅ Preview: https://open-event-fronte-git-fork-iamareebjamal-speaker-toggle-cd4435.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #4581 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4581      +/-   ##
===============================================
- Coverage        22.28%   22.27%   -0.01%     
===============================================
  Files              474      474              
  Lines             4985     4987       +2     
  Branches             8        8              
===============================================
  Hits              1111     1111              
- Misses            3873     3875       +2     
  Partials             1        1              
Impacted Files Coverage Δ
app/components/forms/session-speaker-form.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490ec01...b5317fa. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 008b5eb into fossasia:development Jul 20, 2020
@iamareebjamal iamareebjamal deleted the speaker-toggle-session branch July 20, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer: Creating a session or speaker through the organizer UI without filling it in creates an empty speaker or session
2 participants