chore: Angle Brackets Codemod on app/template/accounts/

[jaydgruber]

What

• removes ember-cli-template-lint in favor of using ember-template-lint directly
  • ref: ember-cli-linter deprecations, which moves to simplify lint calling styles and make them more similar across js & hbs lint
  • a major bump of ember-template-lint is required to use the overrides configuration, which will be helpful to make incremental progress on codemods
• runs the ember-angle-brackets-codemod on app/template/accounts/
• enables the template-lint rule no-curly-component-invocation on the same directory to prevent backsliding

Why

• incremental progress on conversion to angle bracket syntax
• suggestions to resolve some of the frustration expressed on chore: Convert components to angle bracket syntax #4298

Suggestions for a path forward

• ask for help earlier before getting frustrated! Join the community over in Discord
  • #topic-octane-migration #e-template-lint channels may be of interest
• leverage existing tools!
  • most codemods have a paired lint rule in eslint-plugin-ember or ember-template-lint
• find ways to break the work down into smaller chunks. pull request recommendations suggest ~250 lines of code for the average code review to reduce burden on the reviewer. 250 files is too much!
  • Personally, I have found that codemods are ok to be a bit bigger in size than your normal code review, since they are just making a repetitive change over and over. Feedback from my team tells me ~50 files changed is a reasonable limit for codemod PRs, to resepect their time
  • Help your reviewers out with good PR descriptions. 95% of a codemod PR is going to be the same change. If you have to make any additional manual changes, call them out clearly in the PR description so that reviewers can pay extra attention to those. If you find yourself writing more than ~5-10 types of manual change in a codemod PR description... maybe a good time to split off into the next incremental PR
• momentum is important. find ways to keep making progress each day. If you find yourself stuck, instead of going in circles on the same problem:
  • find a way to isolate it to a smaller set of files. hopefully you can isolate to a single test, and filter your test page so that you can get faster feedback
  • again, ask for help in the Discord. if you think the problem is with another OSS library, open an issue
  • normally I would suggest also looking for addon version bumps, but it seems like this repo has dependabot set up, so that's great!
  • keep moving. if you spend more than a few hours stuck on the same problem, draw as small a box around it as you can with glob patterns and a lint rule, but don't let it stop you from converting all of its neighboring files

lint cli changes

• if you choose to make the switch to using ember-template-lint directly, I'd suggest making a few changes to your local dev & CI setup for linting:
  • add a lint:hbs script along-side your lint:js & lint:scss package scripts
  • use npm-run-all to add a lint script to run all three
  • consider setting up lint-staged or similar for easy git hooks. having a pre-commit hook that runs all applicable lint on changed files has been very positively received by my dev team while I am making a lot of lint changes. fast feedback is important.
  • make sure you make the appropriate changes to your Travis CI to include a lint job, since without ember-cli-template-lint it will no longer run during ember test
  • ref: Use eslint and ember-template-lint directly (no longer lint during builds/rebuilds by default) ember-cli/ember-cli#9009

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the Upstream development branch.
• The acceptance, integration, unit tests and linter pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/2mwmb9kyo
✅ Preview: https://open-event-frontend-git-fork-jaydgruber-angle-brackets-upgrade.eventyay.now.sh

[codecov]

Codecov Report

Merging #4301 into development will increase coverage by 0.06%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #4301      +/-   ##
===============================================
+ Coverage        22.72%   22.78%   +0.06%     
===============================================
  Files              468      468              
  Lines             4932     4932              
  Branches             5        5              
===============================================
+ Hits              1121     1124       +3     
+ Misses            3809     3806       -3     
  Partials             2        2              

Impacted Files	Coverage Δ
app/components/tabbed-navigation.js	53.33% <0.00%> (+20.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222b0ec...22f6b62. Read the comment docs.

[iamareebjamal]

Thanks again @jaydgruber for your suggestions and help <3

[iamareebjamal]

This is broken. Same case as #4298