Skip to content

chore: Convert components to angle bracket syntax #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

iamareebjamal
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Apr 5, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/3ohbww2q4
✅ Preview: https://open-event-frontend-git-fork-iamareebjamal-angle-bracket.eventyay.now.sh

@vercel vercel bot temporarily deployed to Preview April 5, 2020 22:41 Inactive
@auto-label auto-label bot added the chore label Apr 5, 2020
@iamareebjamal
Copy link
Member Author

If you're spending 4x time on solving framework compatibility issues and bugs as compared to fixing bugs and adding features in your own project, there is something seriously wrong in that framework :(((

@iamareebjamal
Copy link
Member Author

Spent 2 hours chasing useless errors and indecipherable stacktraces

@kushthedude
Copy link
Member

Spent 2 hours chasing useless errors and indecipherable stacktraces

But alas, Build is still failing 🏗

@iamareebjamal
Copy link
Member Author

It never was successful. This is the thing with ember. I'll try something, it'll fail. I'll curse and vent and come back a week later to be detective again in a crime where I myself am the murderer and the murdered and solve it and break something again and repeat

@iamareebjamal
Copy link
Member Author

So bye for another week and I'll fix it and break something again probably

@snitin315
Copy link
Member

Maybe its time to create a new branch and start migrating the project to react bit by bit.
not an easy task 😞

@iamareebjamal
Copy link
Member Author

Let's check by upgrading to octane first and see if it works out. None of it is easy. Neither migrating to react/vue

@iamareebjamal
Copy link
Member Author

I feel like it is some kind of joke where in one place, it is said to upgrade to latest ember and someone else says stay classic
https://twitter.com/mwpastore/status/1246980602412351489

@kushthedude
Copy link
Member

kushthedude commented Apr 6, 2020 via email

@iamareebjamal
Copy link
Member Author

The weird thing about anyone who is defending ember here is that no one among them is creating PRs to move the project further. I am. And it is exhausting debugging this stuff. So, maybe if @kushthedude can move the project ahead by fixing the PR and handling other required changes to get the project to latest standard. Or should we wait for it to be deprecated?

@kushthedude
Copy link
Member

The weird thing about anyone who is defending ember here is that no one among them is creating PRs to move the project further. I am. And it is exhausting debugging this stuff. So, maybe if @kushthedude can move the project ahead by fixing the PR and handling other required changes to get the project to latest standard. Or should we wait for it to be deprecated?

I was just explaining that guy's point of view. Also, I was not the one to choose Ember for the project.

@iamareebjamal
Copy link
Member Author

The migration we are doing here is not octane, it is ES6 classes and angle bracket syntax. And it is not even problem with it, at least ember has codemods. But the debugging is too difficult that it took me an hour to get which component was throwing an error and the error was completely unrelated as well. It originated from ember composable helpers sort by which would not even be needed if ember did not use hbs.

  1. Debugging is terribly hard
  2. HBS is atrocious to work with and needs 3rd party packages to get basic stuff
  3. Packages are not maintained (issue open for 6 months in repo)

@snitin315
Copy link
Member

Ember is a nightmare

@jaydgruber
Copy link
Contributor

Hi folks. Please take a look at #4301, which hopefully should provide a template for a more incremental path forward

Also, from personal experience, when I see a team really struggling with and fighting with Ember, and venting some frustration like this, it is because they are cut off from the community.

The majority of Ember developers are not putting their problems and answers up on StackOverflow as you might be used to from other ecosystems. It can be frustrating to google a problem and not find any answers. The best way to find help is to drop into the discord and, I suggest the #topic-octane-migration channel. I think you will find a very welcoming and helpful community there

iamareebjamal added a commit to iamareebjamal/open-event-frontend that referenced this pull request Apr 16, 2020
{{sort_by}} was being treated as a composable helper
and thus all builds like fossasia#4301 and mainly fossasia#4298 were breaking
Some changes were reverted in fossasia#4322, but changing to
{{this.sort_by}} makes it unambiguous and also octane
compatible
iamareebjamal added a commit that referenced this pull request Apr 16, 2020
{{sort_by}} was being treated as a composable helper
and thus all builds like #4301 and mainly #4298 were breaking
Some changes were reverted in #4322, but changing to
{{this.sort_by}} makes it unambiguous and also octane
compatible
@iamareebjamal
Copy link
Member Author

Finally! Fingers crossed!!!

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #4298 into development will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4298      +/-   ##
===============================================
- Coverage        22.78%   22.72%   -0.07%     
===============================================
  Files              468      468              
  Lines             4932     4932              
  Branches             5        5              
===============================================
- Hits              1124     1121       -3     
- Misses            3806     3809       +3     
  Partials             2        2              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82070f7...e99ba73. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 82e19e1 into fossasia:development Apr 16, 2020
@iamareebjamal iamareebjamal deleted the angle-bracket branch April 16, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants