-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: Convert components to angle bracket syntax #4298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert components to angle bracket syntax #4298
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/eventyay/open-event-frontend/3ohbww2q4 |
f5a0fb1
to
5171121
Compare
If you're spending 4x time on solving framework compatibility issues and bugs as compared to fixing bugs and adding features in your own project, there is something seriously wrong in that framework :((( |
Spent 2 hours chasing useless errors and indecipherable stacktraces |
But alas, Build is still failing 🏗 |
It never was successful. This is the thing with ember. I'll try something, it'll fail. I'll curse and vent and come back a week later to be detective again in a crime where I myself am the murderer and the murdered and solve it and break something again and repeat |
So bye for another week and I'll fix it and break something again probably |
Maybe its time to create a new branch and start migrating the project to react bit by bit. |
Let's check by upgrading to octane first and see if it works out. None of it is easy. Neither migrating to react/vue |
I feel like it is some kind of joke where in one place, it is said to upgrade to latest ember and someone else says stay classic |
Octane is new, but ember has still not dropped support for classic format.
Anyway sooner or later, it will drop support and move away from classic
forever. So we would need to upgrade anyway, only advantage we can get
later is some new and efficient codemods which may not require a lot of
labour work perhaps.
…On Mon, 6 Apr, 2020, 7:42 AM Areeb Jamal, ***@***.***> wrote:
I feel like it is some kind of joke where in one place, it is said to
upgrade to latest ember and someone else says stay classic
https://twitter.com/mwpastore/status/1246980602412351489
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4298 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLW4SWHTWAQPZYRENHDRLE3AFANCNFSM4MBRZLSA>
.
|
The weird thing about anyone who is defending ember here is that no one among them is creating PRs to move the project further. I am. And it is exhausting debugging this stuff. So, maybe if @kushthedude can move the project ahead by fixing the PR and handling other required changes to get the project to latest standard. Or should we wait for it to be deprecated? |
I was just explaining that guy's point of view. Also, I was not the one to choose Ember for the project. |
The migration we are doing here is not octane, it is ES6 classes and angle bracket syntax. And it is not even problem with it, at least ember has codemods. But the debugging is too difficult that it took me an hour to get which component was throwing an error and the error was completely unrelated as well. It originated from ember composable helpers
|
Ember is a nightmare |
Hi folks. Please take a look at #4301, which hopefully should provide a template for a more incremental path forward Also, from personal experience, when I see a team really struggling with and fighting with Ember, and venting some frustration like this, it is because they are cut off from the community. The majority of Ember developers are not putting their problems and answers up on StackOverflow as you might be used to from other ecosystems. It can be frustrating to google a problem and not find any answers. The best way to find help is to drop into the discord and, I suggest the |
{{sort_by}} was being treated as a composable helper and thus all builds like fossasia#4301 and mainly fossasia#4298 were breaking Some changes were reverted in fossasia#4322, but changing to {{this.sort_by}} makes it unambiguous and also octane compatible
5171121
to
cdd6e53
Compare
Finally! Fingers crossed!!! |
Codecov Report
@@ Coverage Diff @@
## development #4298 +/- ##
===============================================
- Coverage 22.78% 22.72% -0.07%
===============================================
Files 468 468
Lines 4932 4932
Branches 5 5
===============================================
- Hits 1124 1121 -3
- Misses 3806 3809 +3
Partials 2 2
Continue to review full report at Codecov.
|
No description provided.