Implemented best practices and project structure, fix data loading and UITests, update event model and cocoapods #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with fork
sync with upstream :wq
ghost
added
the
chashmeetsingh
approved these changes
Apr 18, 2018
|
Hi @imjog! It looks like one or more of your builds have failed.
|
jogendra
force-pushed
the
structured
branch
4 times, most recently
from
23ed744 to
ac67492
Compare
|
Hi @imjog! It looks like one or more of your builds have failed.
|
|
Hi @imjog! It looks like one or more of your builds have failed.
|
|
Hi @imjog! It looks like one or more of your builds have failed.
|
jogendra
force-pushed
the
structured
branch
2 times, most recently
from
ac67492 to
33e4032
Compare
|
Hi @imjog! It looks like one or more of your builds have failed.
|
jogendra
force-pushed
the
structured
branch
2 times, most recently
from
ac67492 to
57698e0
Compare
|
Hi @imjog! It looks like one or more of your builds have failed.
|
jogendra
force-pushed
the
structured
branch
2 times, most recently
from
ac67492 to
b861b19
Compare
|
Hi @imjog! It looks like one or more of your builds have failed.
|
jogendra
force-pushed
the
structured
branch
2 times, most recently
from
a60482a to
4646183
Compare
jogendra
changed the title
jurvis
approved these changes
Apr 21, 2018
|
|
updated project settings Moved all files constants to Constants file removed outdated UITests Linting fix url endpoint update tracks in event model use `self` to refer to class name as string use DispatchQueue over OperationQueue Fix data loading, update event model with new track ids, and storyboard loading identifiers updated cocoapods to latest 1.5.0
jogendra
changed the title
|
@jurvis @chashmeetsingh @mariobehling Done! Please merge. |
jogendra
added a commit
to jogendra/open-event-ios
that referenced
this pull request
Apr 21, 2018
…sia#55) updated project settings Moved all files constants to Constants file removed outdated UITests Linting fix url endpoint update tracks in event model use `self` to refer to class name as string use DispatchQueue over OperationQueue Fix data loading, update event model with new track ids, and storyboard loading identifiers updated cocoapods to latest 1.5.0
jogendra
added a commit
to jogendra/open-event-ios
that referenced
this pull request
May 27, 2018
…sia#55) updated project settings Moved all files constants to Constants file removed outdated UITests Linting fix url endpoint update tracks in event model use `self` to refer to class name as string use DispatchQueue over OperationQueue Fix data loading, update event model with new track ids, and storyboard loading identifiers updated cocoapods to latest 1.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #28 #53 and part of #30
Changes:
Constants.swiftfile