-
-
Notifications
You must be signed in to change notification settings - Fork 39
Release/1.1.0 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.1.0 #48
Conversation
|
@krvajal, still don't know if i got this right but i'm running the extension tests: And all the tests are passing, but the problem seems to be that this command CI log:
Still studying how to write this tests |
|
Try to run the tests locally and see if you can identify which one is taking longer than expected.
Get Outlook
On Sat, Apr 14, 2018 at 4:51 PM +0200, "Pedro Ricardo C Souza" <notifications@github.com> wrote:
@krvajal, still don't know if i got this right but i'm running the extension tests:
npm install
npm run vscode:prepublish
npm run lint
npm test --silent
And all the tests are passing, but the problem seems to be that this command npm test --silent never ends ... and that's why Travis-CI can't approve. They have a 10min time limit.
CI log:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Still studying how to write this tests
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Not sure if it is a fix ... but returning the |
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage ? 13.21%
=========================================
Files ? 9
Lines ? 348
Branches ? 49
=========================================
Hits ? 46
Misses ? 302
Partials ? 0
Continue to review full report at Codecov.
|
Fixes pre-preocessor directive highlighting
Fix minor highlighting issues
|
Not sure why, but nether of the highlight changes me and kgerheiser proposed are in the 1.1.0 release in vscode extension. But i can see them when I run the extension through extension host in master branch. |
|
I came here looking for the pre-processor highlighting. It doesn't work for me either with the version installed via vscode. |
|
Yes, we are experiencing some problems with the release, if compiled locally in the master branch, the extension have the new pre-processor highlighting fix, although when installed with VSCode it doesn't have the correction. We are looking into it. |
|
What version of the extension do you have installed? Is it 1.1.0 or 1.1.1 |
|
It was a mistake on my side. I made the release while been on the wrong branch so the changes were not reflected properly. I have published a patched version (1.1.2) that should solve the issue. Please let me know if this is the case. |

After merging #47 #46 we can release a new version.
Release checklist