Skip to content

Conversation

@krvajal
Copy link
Collaborator

@krvajal krvajal commented Apr 12, 2018

After merging #47 #46 we can release a new version.

Release checklist

@pedro-ricardo
Copy link
Collaborator

@krvajal, still don't know if i got this right but i'm running the extension tests:

npm install
npm run vscode:prepublish
npm run lint
npm test --silent

And all the tests are passing, but the problem seems to be that this command npm test --silent never ends ... and that's why Travis-CI can't approve. They have a 10min time limit.

CI log:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Still studying how to write this tests

@krvajal
Copy link
Collaborator Author

krvajal commented Apr 14, 2018 via email

@pedro-ricardo
Copy link
Collaborator

Not sure if it is a fix ... but returning the index.ts file to the original one from VSCode tutorials seems to solve the issue. All tests are performed and passed, and the npm test command exits normally. If you consider this a fix i can make a commit so you can see.

@codecov
Copy link

codecov bot commented Apr 15, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3af3ea4). Click here to learn what that means.
The diff coverage is 17.39%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage          ?   13.21%           
=========================================
  Files             ?        9           
  Lines             ?      348           
  Branches          ?       49           
=========================================
  Hits              ?       46           
  Misses            ?      302           
  Partials          ?        0
Impacted Files Coverage Δ
src/lib/helper.ts 0% <0%> (ø)
src/features/completion-provider.ts 0% <0%> (ø)
src/features/document-symbol-provider.ts 0% <0%> (ø)
src/features/hover-provider.ts 0% <0%> (ø)
src/extension.ts 0% <0%> (ø)
src/features/linter-provider.ts 0% <0%> (ø)
src/lib/tokenizer.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af3ea4...0724956. Read the comment docs.

@krvajal krvajal merged commit b97b533 into master Apr 16, 2018
@krvajal krvajal deleted the release/1.1.0 branch April 16, 2018 00:24
@pedro-ricardo
Copy link
Collaborator

Not sure why, but nether of the highlight changes me and kgerheiser proposed are in the 1.1.0 release in vscode extension. But i can see them when I run the extension through extension host in master branch.

@vkbo
Copy link

vkbo commented Apr 17, 2018

I came here looking for the pre-processor highlighting. It doesn't work for me either with the version installed via vscode.

@pedro-ricardo
Copy link
Collaborator

Yes, we are experiencing some problems with the release, if compiled locally in the master branch, the extension have the new pre-processor highlighting fix, although when installed with VSCode it doesn't have the correction. We are looking into it.

@krvajal
Copy link
Collaborator Author

krvajal commented Apr 17, 2018

What version of the extension do you have installed? Is it 1.1.0 or 1.1.1

@vkbo
Copy link

vkbo commented Apr 17, 2018

I have 1.1.1 installed.

It currently looks like this:
image

The main issue is that it interprets the endif as a fortran endif, otherwise I'm not particularly concerned with the pre-processor lines not being highlighted.

@krvajal
Copy link
Collaborator Author

krvajal commented Apr 17, 2018

It was a mistake on my side. I made the release while been on the wrong branch so the changes were not reflected properly. I have published a patched version (1.1.2) that should solve the issue. Please let me know if this is the case.
And please move the discussion to an issue and not as part of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants