alarm service #597
Merged
alarm service #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
forrestguice
commented
May 12, 2022
forrestguice
commented
- fixes bug "default alarm sound fails to play" (default alarm sound fails to play #593).
- fixes bug "sounding/snoozing notification is unexpectedly canceled" (sounding/snoozing notification is unexpectedly canceled #594).
pass the service startId to alarm receiver listeners
TODO
reject alarm sounds that aren't content:/, file:/ or android.resource:/ .. replace these with the default or fallback.
If playing the default sound fails, make a final attempt using the fallback sound (rtttl).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.