Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default alarm sound fails to play #593

Closed
forrestguice opened this issue May 5, 2022 · 5 comments · Fixed by #595
Closed

default alarm sound fails to play #593

forrestguice opened this issue May 5, 2022 · 5 comments · Fixed by #595
Milestone

Comments

@forrestguice
Copy link
Owner

forrestguice commented May 5, 2022

Describe the bug
The default alarm sound fails to play and instead the alarm is silent.

To Reproduce
Steps to reproduce the behavior:

  1. Add an alarm. Leave the ringtone setting as the default.
  2. Wait for the alarm.. When it eventually triggers there is no sound.
  3. Repeat these steps, except change the ringtone to any other value. The alarm sound plays as expected.

Expected behavior
The default sound should always play (never silent).

Version Info:

  • App Version: v0.14.3

Additional context
This bug was introduced in v0.14.3. It works correctly in previous versions.

@forrestguice
Copy link
Owner Author

forrestguice commented May 5, 2022

Its possible most won't notice this because they make a point of setting the alarm sound. And also possible that someone slept through their alarm because of this. :\

I wish I had noticed this yesterday before tagging v0.14.4, and not really sure how I failed to notice it when testing v0.14.3 .. in fact I swear it was playing correctly then (but since I'm looking at the buggy line that seems unlikely).

forrestguice added a commit that referenced this issue May 5, 2022
AlarmSettingsTest; adds failing tests (#593)
forrestguice added a commit that referenced this issue May 5, 2022
all keys must be unique! a copy/paste error (causes #593)
@forrestguice forrestguice added this to the v0.14.5 milestone May 5, 2022
@Timo-Fi
Copy link

Timo-Fi commented May 8, 2022

It strongly seems to me that Android 11 (Xiaomi, MIUI 12.5) gracefully refuses to show/play any notifications from Suntimes versions 0.14.x, but does show the notification text from version 0.13.9 and earlier, however this Android 11 device either refuses to play the defined audio, and normally refuses to accept the ringtone / audio file -setting that I make. It will play the default notification sound in case I leave it untouched (if I set it to something else, and then back to the default, then it no longer plays). I have done the device settings many times, all the notifications related settings are enabled (less vibration), battery optimization is off and DND overriding is allowed. Having the Suntimes Alarms app either on the background or closed has no effect to the above. I have uninstalled and installed different Suntimes version many times. ... every new Android OS version feeds us some Googlepoo. Luckily my main phone is Android 7 device, the Suntimes 0.14.3 works fully OK on it.

When the default notification sound is defined (in Android 7 setup) to be one of my own file, it will be played by Suntimes (I do not know how it it is with the default tones that come hardwired with the OS/GUI, I never use them, they are pain for the ear). However, if I set the a test notification to be only one or a couple more minutes in the future, it will never trigger. So, I always set test notifications to be over 10 minutes ahead of time, then they are played for sure. Battery optimization is off. But then, another app, a talking clock that I once had installed, told me that "your device does not show time accurately".

@Timo-Fi
Copy link

Timo-Fi commented May 10, 2022

My bad, the Android 11 (Xiaomi, MIUI 12.5) device does show the notifications from Suntimes. Yesterday I uninstalled the 0.14.3 and then installed 0.14.4, created some notifications for testing, and they played OK. Likely I have been too impatient in testing.

@jackthebean
Copy link

Its possible most won't notice this because they make a point of setting the alarm sound. And also possible that someone slept through their alarm because of this. :\

I wish I had noticed this yesterday before tagging v0.14.4, and not really sure how I failed to notice it when testing v0.14.3 .. in fact I swear it was playing correctly then (but since I'm looking at the buggy line that seems unlikely).

Looking forward to having it fixed. Thanks.

This was referenced May 11, 2022
@jackthebean
Copy link

jackthebean commented Sep 27, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants