-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian translation #458
Russian translation #458
Conversation
@rchintsov I'll merge this later this week. If you need to make additional changes, you can continue making commits (and push them), and they will show up here automatically. That should trigger the CI to produce another debug apk. |
@forrestguice Ok, thanks. I'll commit fixes within a hour. |
@forrestguice All job is done. If there are any changes, I think they'll be very small. UPD: Now Suntimes looks like a native Russian application, that is in a way incredible for me. I'm very glad that I had a hand to this, and now, looking at the result, I can't believe it looks so plausible. :) UPD2: My special thanks for the CI pipeline. Without it, I wouldn't be able to add fixes so quickly. |
<b>Action:</b> An action string.<br/><small>e.g. <em>android.intent.action.VIEW</em></small> | ||
<b>Действие:</b> Строка действия. <br/><small>напр. <em>android.intent.action.VIEW</em></small> | ||
<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be "Action: Строка действия." to match the UI (Android specific term).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now it's clear. Thanks.
UPD: fixed.
This looks good. 👍 It does pass for a native app, congrats on the great work. It is very complete, so I tried fixing anything I saw that wasn't translated - a handful of dialogs with untranslated "cancel" buttons. I also fixed those plurals. If you pull this branch they should now be marked I'll give some thought to the note area (to avoid scrolling). I also noted that the It also seems that the 12-hr format (translated) is broken for older devices. My older phone (api19) displays "до полудня" and "после полудня" (way too long), while the latest emulator displays "AM" and "PM". I'm not sure there's anything I can do to fix it - its just the way |
Thanks! And you on expanding your audience!
I imagine nativeness not as fullness of translation, but as nativeness of using the language. Most of translations maked by direct translation of the English words. It looks very rude, I tried to avoid this.
I didn't pay attention for untranslated "cancel" buttons, but I remember UI theme names with degrees of transparency in brackets, that I couldn't translate. It may be more important for users, since we are already used to seeing buttons in English in other apps. Thanks for your attention to scrolling and other. I'm waiting for the opportunity to write more precise wordings of twilights.
I can't answer for all Russian speakers, but I've never seen a person using 12hr time together with the Russian interface. So, don't worry about that. Also, we never think about it, just using the default 24h preset for the Russian locale. P.S.: I just remembered my big surprise when I first encountered 12h time in the school English classes. It was very unusual :) |
btw, its also possible to translate the F-Droid listing. I've added the required files ( We can include those in this pull, or wait for the next patch (most likely ~2 weeks), or the patch after that, etc. |
@forrestguice Ok, I'm in. But I'll do this tomorrow (if I got this right, tomorrow for me and for you - are different things). Anyway, the main point is that we'll be in time. |
@forrestguice I experimented a bit with the look of the permission list and changed the link to Suntimes Calendars. This is because the F-Droid site handle links to itself in its own way (with |
I saw that broken link a few days ago and wondered how to fix it. I was unaware of |
@forrestguice I don't know. I just looked to HTML and saw that the |
@forrestguice Look: now it's displaying good (screen from F-Droid). It remains to remove |
Its looks good. Using the translated description to fine tune this is a good idea. Please experiment more if you'd like, and later I will apply changes to the other files. I'm in favor of removing HTML formatting. It was an experiment, but it seems to look better without. |
Full Russian translation. Based on the original file (follows instructions from CONTRIBUTING.md).
Contains a few TODOs for future work.