Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Times of sunset unreadable on any non-english version #43

Closed
verdulo opened this issue Aug 16, 2016 · 5 comments
Closed

Times of sunset unreadable on any non-english version #43

verdulo opened this issue Aug 16, 2016 · 5 comments
Labels
Milestone

Comments

@verdulo
Copy link
Contributor

verdulo commented Aug 16, 2016

I've checked on 2 phones (with smaller and bigger screen) and times of sunsets and solar-noon go out of the screen on both Polish, Esperanto and German translations. What can be do to fix it:

  1. Shorten the strings "sunrise_short" and "sunset_short", eo/pl versions are ready, now @HerHde needs to update German translation.
  2. The date is currently displayed in 2 lines "Today |next-line| 2016-08-16", maybe in similar way display the column "Rise" and "Set" - display the icon of Sun above or in the next line.
  3. There's lots of unoccupied space between a date and the word "Rise", so maybe align the column "Set" to the right corner of screen, and make width of column "Date" variable.
@HerHde
Copy link
Contributor

HerHde commented Aug 16, 2016

Yeah, this is a bit difficult.
We don't have a rise and set in German, I could write "Auf[gang]" and "Unter[gang]" which means "up" and "down", but this is too ambiguous so I've decided to use "morning" and "evening", even if it is not so short:

-  <string name="sunrise_short">Aufgang</string>
+  <string name="sunrise_short">Morgen</string>
-  <string name="sunset_short">Untergang</string>
+  <string name="sunset_short">Abend</string>

If there is any german user with a better proposal, just write it ;-)

@forrestguice
Copy link
Owner

All good suggestions. I will look into fixing it - changing the layout might be a better fix than changing the strings.

I just discovered I can preview the locale in the android studio design tab - I can see what you are talking about, especially for the smaller screens. The entire sunset column is bumped just out of view :\

forrestguice added a commit that referenced this issue Aug 21, 2016
…s to table_res

prepwork related to #43.
refactors table headers into their own layout files, and header
dimensions into resource file `table_res`.
places constraints (ems/length/#lines constraints) on header columns.
forrestguice added a commit that referenced this issue Aug 21, 2016
refactored nextprev buttons to separate layout file. refactored
"timecard" to separate layout file. cleanup layout_main. next/prev
buttons moved to bottom right. related to #43 .
@forrestguice
Copy link
Owner

ok, I think the situation is improved. I have put some constraints on the column headers so no matter how long the text those fields shouldn't push other content off the screen. For smaller screens it should ellipse (...) the cutoff portion of the text, and for larger screens the constraints should relax to allow the table to take up more space.

preview (nexus one .. 3.7" screen)
prev1
prev4

preview (nexus 6 .. 6" screen)
prev2
prev3

an alternative .. I think this looks a little awkward, but we can also allow the labels to use two lines instead of one.
prev5

thoughts?

@forrestguice
Copy link
Owner

I am also thinking a "ui setting" here wouldn't be a bad addition - labels display as either "text", "icon", or "text + icon".

@forrestguice forrestguice added this to the v0.2.1 milestone Aug 25, 2016
@9662
Copy link

9662 commented Sep 1, 2016

Not a Polish speaker, though I can understand some. With that said, the two line version looks terrible to me because the words are broken in the middle of a syllable (the -chód in there is a single syllable).

FWIW, I suppose an icon-only preference is one possible option. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants