fix some logic errors #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
bundle exec ruby benchmark.rb
, I ran into an error:It looks like
raise_on_missing_parameter
wasn't passed as a keyword argument in #11. After fixing that, I ran into:This problem also comes from #11, which inadvertently changed the return value of
Interpreter#interpret
. The second commit in this PR fixes that problem, after which the benchmarks run successfully.