Add raise_on_missing_params option to interpreter
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptarjan @vanwagonet could you please take a look and lmk what you think? Happy to elaborate more if needed. Separately, let me know what tests you would like to see for the change! |
|
@ptarjan @vanwagonet friendly ping in case you missed the previous one 🙂 |
vanwagonet
approved these changes
Oct 24, 2022
|
@vanwagonet thanks for the approval! could you merge this change as well 🙏 |
|
I have merged this, but honestly I haven't used ruby in years, and will need to lookup how cut and publish a release. This package is in sore need of a maintainer that is in ruby & gems frequently. |
|
Ah gotcha, I was about to ask how do we do releases 😂 Thanks for adding me as a collaborator, will look into this. |
dwei-stripe
deleted the
dwei-support-raise-on-missing-params-during-interpretation
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows the interpreter to keep track of parameters that it tried to access but which turned out to be
nil, and to raise them in an error when the newly addedraise_on_missing_paramsoption is set totrue.