Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable paths autocompletions #2949

Merged
merged 5 commits into from
Jul 15, 2024
Merged

enable paths autocompletions #2949

merged 5 commits into from
Jul 15, 2024

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Jul 5, 2024

fixes #2935

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="complete_enable_paths")
julia> using Pluto

@Pangoraw Pangoraw marked this pull request as ready for review July 13, 2024 12:00
@fonsp
Copy link
Owner

fonsp commented Jul 13, 2024

Nice! I want path completions to only show when the autocomplete is explicit (TAB was pressed), not automatically on type.

@fonsp fonsp added frontend Concerning the HTML editor CM6 CodeMirror 6 autocomplete <TAB> labels Jul 13, 2024
@Pangoraw
Copy link
Collaborator Author

ah that makes sense, i made it work only for explicit completions and when the query contains '/' since there are a lot of false positives otherwise.

@fonsp
Copy link
Owner

fonsp commented Jul 15, 2024

Really nice, thanks!!

@fonsp fonsp merged commit c247126 into main Jul 15, 2024
10 of 13 checks passed
@fonsp fonsp deleted the complete_enable_paths branch July 15, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete <TAB> CM6 CodeMirror 6 frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No path completions
2 participants