-
Notifications
You must be signed in to change notification settings - Fork 234
Make fontkit cross-platform compatible again #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…default OS-presupplied utilities
|
@devongovett probably worth landing, to unblock Windows users (either by choice or because work demands it) since CI says it's all good =) |
|
Not sure how I feel about this. Doesn't Windows have bash now? What about cygwin? Admittedly my knowledge of windows is very limited, but Make is a tool that's designed exactly for this purpose. npm scripts are not. |
|
This is exactly what npm scripts were designed for, too, and have the benefit of actually working on Windows, whereas That said, the Linux Subsystem is still in beta, so you can't really rely on it. Cygwin is massively huge, and for node projects there isn't a single thing in Cygwin that isn't already covered by node/npm packages that have clean CLI invocations. There is literally no reason to have any kind of reliance on This PR simply ports the instructions you had in the Makefile to a form that fits "the proper node way" of bootstrapping and using CLI-based task running without baking in anything that's platform specific and prevents the project from running on one or more operating systems. |
|
(I agree with Mike :)
|
|
hm. bump? |
|
bump, again? =) |
|
rerebump =) (feel free to close it, but it would still benefit loads of people to merge this without any change in build funcationality) |
|
@devongovett this is still very much worth landing If you no longer really work on fontkit, could I selfishly ask you just hit merge so that people who do still use it a lot in the font work can use this normally on windows, without affecting anyone on nx operating systems? It doesn't get in your or anyone else's way, but does make life much easier for an estimated 50% of the developer community. |
|
Thank you Devon!!
|
|
Yeah sorry guys, I've been busy with other projects lately. Today I made an org https://github.com/foliojs and I'll be moving fontkit, textkit, pdfkit, and all related dependencies across the whole stack there so more contributors can be involved with reviewing and merging code. @diegomura of react-pdf is already helping out a bit, and I hope to bring others on as maintainers as well. Hopefully that will help with the long term support for these projects. |
|
That's great to hear! |
Closes #118
This makes everything node-runnable again, obviating the need for OS-presupplied utilities. It adds
npm-run-allas a script running convenience, and it addsshxas cross-platform utility runner for common unix utils such ascpandrm. Finally, it also addscross-envto ensure that environment variables are set in a way that work in unix, linux, OSX, and Windows alike.npm testshows all tests passing, with the same coverage.