Get device name from android devices. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnando
force-pushed
the
android-device-names
branch
from
6175072 to
6f90238
Compare
fnando
force-pushed
the
master
branch
2 times, most recently
from
efdcd67 to
2565ccc
Compare
|
can u merge this? so at least we've the device name |
fnando
force-pushed
the
android-device-names
branch
from
6f90238 to
c68e491
Compare
fnando
force-pushed
the
android-device-names
branch
from
c68e491 to
3b15c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #231.
The biggest issue here is which id should be returned. We can't dynamically generate it because we need a reliable value.