Apply rubocop suggestions.

.rubocop.yml

@@ -1,3 +1,16 @@
+AllCops:
+  Exclude:
+    - "bin/**/*"
+    - "gemfiles/**/*"
+    - "vendor/**/*"
+    - "Gemfile"
+    - "Rakefile"
+    - "*.gemspec"
+    - "config.ru"
+
+Style/Alias:
+  EnforcedStyle: prefer_alias_method
+
 Style/FrozenStringLiteralComment:
   EnforcedStyle: always
 
@@ -58,7 +71,7 @@ SingleLineBlockParams:
 VariableInterpolation:
   Enabled: false
 
-TrailingComma:
+Style/TrailingCommaInLiteral:
   Enabled: false
 
 WhileUntilModifier:

Rakefile

@@ -12,6 +12,12 @@ Rake::TestTask.new(:test) do |t|
   t.ruby_opts = %w[-rubygems]
 end
 
+require "rubocop/rake_task"
+desc "Run rubocop"
+task :rubocop do
+  RuboCop::RakeTask.new
+end
+
 desc "Run specs against all gemfiles"
 task "test:all" do
   %w[
@@ -23,4 +29,4 @@ task "test:all" do
   end
 end
 
-task default: "test"
+task default: [:test, :rubocop]

browser.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "pry-meta"
   s.add_development_dependency "minitest-autotest"
   s.add_development_dependency "codeclimate-test-reporter"
+  s.add_development_dependency "rubocop"
 end

lib/browser/alipay.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Browser
   class Alipay < Base
     def id

lib/browser/detect_version.rb

@@ -11,11 +11,11 @@ def detect_version?(actual_version, expected_version)
       actual_version = parse_version(actual_version)
 
       Gem::Requirement.create(expected_version)
-        .satisfied_by?(Gem::Version.create(actual_version))
+                      .satisfied_by?(Gem::Version.create(actual_version))
     end
 
     def parse_version(version)
-      version.kind_of?(Numeric) ? "#{version}" : version
+      version.kind_of?(Numeric) ? version.to_s : version
     end
   end
 end

lib/browser/device.rb

@@ -52,8 +52,8 @@ def initialize(ua)
 
     def subject
       @subject ||= self.class.matchers
-                   .map {|matcher| matcher.new(ua) }
-                   .find(&:match?)
+                       .map {|matcher| matcher.new(ua) }
+                       .find(&:match?)
     end
 
     def id

lib/browser/generic.rb

@@ -4,7 +4,7 @@ class Generic < Base
     NAMES = {
       "QuickTime" => "QuickTime",
       "CoreMedia" => "Apple CoreMedia"
-    }
+    }.freeze
 
     def id
       :generic

lib/browser/internet_explorer.rb

@@ -8,7 +8,7 @@ class InternetExplorer < Base
       "6.0" => "10",
       "7.0" => "11",
       "8.0" => "12"
-    }
+    }.freeze
 
     def id
       :ie

lib/browser/micro_messenger.rb

@@ -17,4 +17,4 @@ def match?
       ua =~ /MicroMessenger/i
     end
   end
-end
+end

lib/browser/middleware.rb

@@ -11,7 +11,7 @@ class Middleware
     ACCEPT_REGEX = %r[(text/html|\*/\*)]
 
     def initialize(app, &block)
-      fail ArgumentError, "Browser::Middleware requires a block" unless block
+      raise ArgumentError, "Browser::Middleware requires a block" unless block
 
       @app = app
       @block = block

lib/browser/platform.rb

@@ -44,8 +44,8 @@ def initialize(ua)
 
     def subject
       @subject ||= self.class.matchers
-                   .map {|matcher| matcher.new(ua) }
-                   .find(&:match?)
+                       .map {|matcher| matcher.new(ua) }
+                       .find(&:match?)
     end
 
     def adobe_air?

lib/browser/platform/mac.rb

@@ -3,7 +3,7 @@ module Browser
   class Platform
     class Mac < Base
       def version
-        (ua[/Mac OS X\s*([0-9_\.]+)?/, 1] || "0").gsub("_", ".")
+        (ua[/Mac OS X\s*([0-9_\.]+)?/, 1] || "0").tr("_", ".")
       end
 
       def name

lib/browser/testing.rb

@@ -15,7 +15,9 @@ def self.bot_user_agents
   end
 
   def self.search_engine_user_agents
-    @search_engine_user_agents ||= YAML.load_file(Browser.root.join("test/ua_search_engines.yml"))
+    @search_engine_user_agents ||= begin
+      YAML.load_file(Browser.root.join("test/ua_search_engines.yml"))
+    end
   end
 
   def self.[](key)

lib/browser/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Browser
-  VERSION = "2.2.0"
+  VERSION = "2.2.0".freeze
 end

test/browser_test.rb

@@ -124,8 +124,11 @@ class BrowserTest < Minitest::Test
   end
 
   test "returns all known languages" do
-    browser = Browser.new("", accept_language: "en-us,en;q=0.8,pt-br;q=0.5,pt;q=0.3")
-    assert_equal ["en-US", "en", "pt-BR", "pt"], browser.accept_language.map(&:full)
+    accept_language = "en-us,en;q=0.8,pt-br;q=0.5,pt;q=0.3"
+    browser = Browser.new("", accept_language: accept_language)
+    languages = browser.accept_language.map(&:full)
+
+    assert_equal ["en-US", "en", "pt-BR", "pt"], languages
   end
 
   test "removes duplicate items" do

test/unit/accept_language_test.rb

@@ -62,7 +62,8 @@ def assert_language(item, expect = {})
   end
 
   test "parses complex set" do
-    result = Browser::AcceptLanguage.parse("fr-CA,fr;q=0.8,en-US;q=0.6,en;q=0.4,*;q=0.1")
+    accept_language = "fr-CA,fr;q=0.8,en-US;q=0.6,en;q=0.4,*;q=0.1"
+    result = Browser::AcceptLanguage.parse(accept_language)
 
     assert_language result[0], code: "fr", region: "CA", quality: 1.0
     assert_language result[1], code: "fr", region: nil, quality: 0.8
@@ -72,7 +73,8 @@ def assert_language(item, expect = {})
   end
 
   test "handles random white spaces" do
-    result = Browser::AcceptLanguage.parse("fr-CA, fr;q=0.8,  en-US;q=0.6,en;q=0.4,    *;q=0.1")
+    accept_language = "fr-CA, fr;q=0.8,  en-US;q=0.6,en;q=0.4,    *;q=0.1"
+    result = Browser::AcceptLanguage.parse(accept_language)
 
     assert_language result[0], code: "fr", region: "CA", quality: 1.0
     assert_language result[1], code: "fr", region: nil, quality: 0.8
@@ -82,7 +84,8 @@ def assert_language(item, expect = {})
   end
 
   test "sorts based on quality" do
-    result = Browser::AcceptLanguage.parse("fr-CA,fr;q=0.2,en-US;q=0.6,en;q=0.4,*;q=0.5")
+    accept_language = "fr-CA,fr;q=0.2,en-US;q=0.6,en;q=0.4,*;q=0.5"
+    result = Browser::AcceptLanguage.parse(accept_language)
 
     assert_language result[0], code: "fr", region: "CA", quality: 1.0
     assert_language result[1], code: "en", region: "US", quality: 0.6

test/unit/alipay_test.rb

@@ -4,8 +4,6 @@
 class AlipayTest < Minitest::Test
   test "detects alipay iOS" do
     browser = Browser.new(Browser["ALIPAY_IOS"])
-    puts browser.id
-    puts browser.name
 
     assert_equal :alipay, browser.id
     assert browser.alipay?

test/unit/generic_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 class GenericTest < Minitest::Test

test/unit/meta_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 class MetaTest < Minitest::Test