Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed initialisation of layers/boundaries, technical grid needs updating #407

Merged
merged 2 commits into from
May 15, 2019
Merged

Fixed initialisation of layers/boundaries, technical grid needs updating #407

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
870f9e2
Fixed initialisation of layers/boundaries, technical grid needs updat…
ykempf May 15, 2019
af0e268
Moved technicalGrid.updateGhostCells to where technicalGrid things ar…
ykempf May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed initialisation of layers/boundaries, technical grid needs updat… 
…ing.
  • Loading branch information
@ykempf
ykempf committed May 15, 2019
commit 870f9e217dd05192370bf38af93138f9ad54be54
3 changes: 3 additions & 0 deletions sysboundary/sysboundary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ bool SysBoundary::classifyCells(dccrg::Dccrg<spatial_cell::SpatialCell,dccrg::Ca
// sysBoundaryLayer communicated)
SpatialCell::set_mpi_transfer_type(Transfer::CELL_SYSBOUNDARYFLAG);
mpiGrid.update_copies_of_remote_neighbors(SYSBOUNDARIES_NEIGHBORHOOD_ID);
technicalGrid.updateGhostCells();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that I would move this to around line 477, so that the technical grid layer computation is in one place. Now the dccrg layer computation is inbetween

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that it is fine :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like so?


// set distance 1 cells to boundary cells, that have neighbors which are normal cells
for(uint i=0; i<cells.size(); i++) {
Expand Down Expand Up @@ -495,11 +496,13 @@ bool SysBoundary::classifyCells(dccrg::Dccrg<spatial_cell::SpatialCell,dccrg::Ca
if (layer > 2 && technicalGrid.get(x,y,z)->sysBoundaryFlag != sysboundarytype::NOT_SYSBOUNDARY) {
technicalGrid.get(x,y,z)->sysBoundaryFlag = sysboundarytype::DO_NOT_COMPUTE;
}

}
}
}
}
}
technicalGrid.updateGhostCells();
}

// One more pass to make sure, in particular if the ionosphere is wide enough
Expand Down