Fixed initialisation of layers/boundaries, technical grid needs updating #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first reviewer who is ok with this can merge it. :) |
galfthan
reviewed
May 15, 2019
sysboundary/sysboundary.cpp
Outdated
| @@ -409,6 +409,7 @@ bool SysBoundary::classifyCells(dccrg::Dccrg<spatial_cell::SpatialCell,dccrg::Ca | |||
| // sysBoundaryLayer communicated) | |||
| SpatialCell::set_mpi_transfer_type(Transfer::CELL_SYSBOUNDARYFLAG); | |||
| mpiGrid.update_copies_of_remote_neighbors(SYSBOUNDARIES_NEIGHBORHOOD_ID); | |||
| technicalGrid.updateGhostCells(); | |||
There was a problem hiding this comment.
My only comment is that I would move this to around line 477, so that the technical grid layer computation is in one place. Now the dccrg layer computation is inbetween
|
Does this mean the "No closest cells found!" (ionosphere.cpp, line 553) check should be kept in? |
|
Yes, it does. That was also the topic of one of yesterday's PRs, but there were more problems with this algorithm there initialising the layers and setting DO_NOT_COMPUTE cells... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My suggestion, posted as a PR for safety...