GH-5768: Better pyflyte boolean parsing #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Newton
force-pushed
the
tomnewton/better_pyflyte_boolean_parsing/GH-5768
branch
from
9658cbe
to
a0fe865
Compare
2 tasks
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/better_pyflyte_boolean_parsing/GH-5768
branch
from
a0fe865
to
65807ff
Compare
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/better_pyflyte_boolean_parsing/GH-5768
branch
from
f4b89c0
to
928bee3
Compare
Tom-Newton
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/better_pyflyte_boolean_parsing/GH-5768
branch
from
b844fa3
to
604f07c
Compare
eapolinario
reviewed
Sep 23, 2024
pingsutw
reviewed
Sep 23, 2024
pingsutw
reviewed
Sep 23, 2024
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
force-pushed
the
tomnewton/better_pyflyte_boolean_parsing/GH-5768
branch
from
0cad3a5
to
34466a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2764 +/- ##
===========================================
+ Coverage 78.98% 92.13% +13.14%
===========================================
Files 194 19 -175
Lines 19807 1309 -18498
Branches 4130 0 -4130
===========================================
- Hits 15645 1206 -14439
+ Misses 3443 103 -3340
+ Partials 719 0 -719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
previously approved these changes
Sep 23, 2024
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#999
Why are the changes needed?
The current boolean parsing behaviour is confusing for default True arguments.
What changes were proposed in this pull request?
Add
--no_...and--no-...variants for boolean flags as per the recommendation at https://click.palletsprojects.com/en/8.1.x/options/#boolean-flagsHow was this patch tested?
Wrote new unit tests to cover it.
Setup process
Screenshots
Check all the applicable boxes
--helpshould be automatically taken care of by theclicklibrary.Related PRs
Docs link