[BUG] Confusing behaviour with default True boolean arguments when using pyflyte run

[Tom-Newton]

Describe the bug

Adding --paramater name on a deafault true boolean paramater causes the workflow to run with the value as False.

Example:

from flytekit import task, workflow


@task
def task0(test_bool: bool) -> bool:
    return test_bool


@workflow
def workflow0(test_bool: bool = True) -> bool:
    return task0(test_bool=test_bool)

The default works as expected:

$ pyflyte run workflow2.py workflow0
Running Execution on local.
True

Adding --test_bool causes unexpected behaviour where it uses False is used

$ pyflyte run workflow2.py workflow0 --test_bool
Running Execution on local.
False

Expected behavior

Based on https://click.palletsprojects.com/en/8.1.x/options/#boolean-flags I would expect

$ pyflyte run workflow2.py workflow0
Running Execution on local.
True

$ pyflyte run workflow2.py workflow0 --test_bool
Running Execution on local.
True

$ pyflyte run workflow2.py workflow0 --no_test_bool
Running Execution on local.
False

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[Tom-Newton]

If we think this is sensible I made a PR which implements it flyteorg/flytekit#2764