Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backfill command #2730

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix backfill command #2730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions flytekit/remote/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,9 +781,13 @@
# serial register
cp_other_entities = OrderedDict(filter(lambda x: not isinstance(x[1], task_models.TaskSpec), m.items()))
for entity, cp_entity in cp_other_entities.items():
identifiers_or_exceptions.append(
self.raw_register(cp_entity, serialization_settings, version, og_entity=entity)
)
try:
identifiers_or_exceptions.append(

Check warning on line 785 in flytekit/remote/remote.py

View check run for this annotation

Codecov / codecov/patch

flytekit/remote/remote.py#L784-L785 

Added lines #L784 - L785 were not covered by tests
self.raw_register(cp_entity, serialization_settings, version, og_entity=entity)
)
except RegistrationSkipped as e:
logger.info(f"Skipping registration... {e}")
continue

Check warning on line 790 in flytekit/remote/remote.py

View check run for this annotation

Codecov / codecov/patch

flytekit/remote/remote.py#L788-L790 

Added lines #L788 - L790 were not covered by tests
return identifiers_or_exceptions[-1]

def register_task(
Expand Down
Loading