Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backfill command #2730

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix backfill command #2730

merged 1 commit into from
Sep 5, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Sep 4, 2024

Tracking issue

NA

Why are the changes needed?

Failed to run backfill command

│    785 │   │   │   │   identifiers_or_exceptions.append(                                         │
│ ❱  786 │   │   │   │   │   self.raw_register(cp_entity, serialization_settings, version, og_ent  │
│    787 │   │   │   │   )                                                                         │
│    788 │   │   │   except RegistrationSkipped as e:                                              │
│    789 │   │   │   │   logger.info(f"Skipping registration... {e}")                              │
│                                                                                                  │
│ /Users/kevin/git/flytekit/flytekit/remote/remote.py:661 in raw_register                          │
│                                                                                                  │
│    658 │   │   │   │   │   raise RegistrationSkipped(f"Remote task/Workflow {cp_entity.name} is  │
│    659 │   │   │   else:                                                                         │
│    660 │   │   │   │   logger.debug(f"Skipping registration of remote entity: {cp_entity.name}"
│ ❱  661 │   │   │   │   raise RegistrationSkipped(f"Remote entity {cp_entity.name} is not regist  │
│    662 │   │                                                                                     │
│    663 │   │   if isinstance(                                                                    │
│    664 │   │   │   cp_entity,                                                                    │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
RegistrationSkipped: Remote entity pyl510_lp is not registrable.

What changes were proposed in this pull request?

Ignore RegistrationSkipped error during registration

How was this patch tested?

pyflyte -v backfill --from-date "2023-10-27 15:30:00" --to-date "2023-10-29 16:40:00"  pyl510_lp

Setup process

Screenshots

Screenshot 2024-09-04 at 2 38 05 PM

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (8bad8e6) to head (ee42367).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/remote/remote.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2730       +/-   ##
===========================================
+ Coverage   49.76%   78.36%   +28.60%     
===========================================
  Files         193      193               
  Lines       19659    19672       +13     
  Branches     4097     4100        +3     
===========================================
+ Hits         9783    15416     +5633     
+ Misses       9345     3537     -5808     
- Partials      531      719      +188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit a9c9c46 into master Sep 5, 2024
102 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants