Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote] check subworkflows for launch plan nodes #2714

Merged
merged 4 commits into from
Aug 27, 2024
Merged

[Remote] check subworkflows for launch plan nodes #2714

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
791fff3
check subworkflows also for laucnh plans
wild-endeavor Aug 26, 2024
f92176e
revert printing
wild-endeavor Aug 26, 2024
9c6a9f9
cache launch plan call... we should cache all the other ones too, sep…
wild-endeavor Aug 26, 2024
26dff23
also task/wf
wild-endeavor Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions flytekit/remote/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2136,15 +2136,17 @@ def sync_node_execution(
compiled_wf = node_execution_get_data_response.dynamic_workflow.compiled_workflow
node_launch_plans = {}
# TODO: Inspect branch nodes for launch plans
for node in FlyteWorkflow.get_non_system_nodes(compiled_wf.primary.template.nodes):
if (
node.workflow_node is not None
and node.workflow_node.launchplan_ref is not None
and node.workflow_node.launchplan_ref not in node_launch_plans
):
node_launch_plans[node.workflow_node.launchplan_ref] = self.client.get_launch_plan(
node.workflow_node.launchplan_ref
).spec
for template in [compiled_wf.primary.template] + [swf.template for swf in compiled_wf.sub_workflows]:
for node in FlyteWorkflow.get_non_system_nodes(template.nodes):
if (
node.workflow_node is not None
and node.workflow_node.launchplan_ref is not None
and node.workflow_node.launchplan_ref not in node_launch_plans
):
logger.warning(f"Fetching launch plan {node.workflow_node.launchplan_ref.name}")
node_launch_plans[node.workflow_node.launchplan_ref] = self.client.get_launch_plan(
node.workflow_node.launchplan_ref
).spec

dynamic_flyte_wf = FlyteWorkflow.promote_from_closure(compiled_wf, node_launch_plans)
execution._underlying_node_executions = [
Expand Down
Loading