Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote] check subworkflows for launch plan nodes #2714

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Aug 26, 2024

Why are the changes needed?

Launch plans are not included in closures fetched from Admin because they always refer to and are defined by the ones in Admin. When FlyteRemote scans for launch plan definitions, it should scan for both the primary as well as any subworkflows.

What changes were proposed in this pull request?

In addition to the primary workflow template, also check subworkflow templates.

  • Also add an lru cache to the get launch plan/wf/task call in the friendly clients, ideally we go through all the friendly client functions and cache all the ones that make sense to, but this determination should be done in a separate pr.
    • Note that the lru cache does not cache exceptions, so if the underlying entity is missing, it will not be cached.

How was this patch tested?

Tested against a live control plane.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
eapolinario
eapolinario previously approved these changes Aug 26, 2024
…arate pr i think

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor changed the title check subworkflows also for laucnh plans [Remote] check subworkflows for launch plan nodes Aug 26, 2024
@wild-endeavor wild-endeavor marked this pull request as ready for review August 26, 2024 23:47
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor enabled auto-merge (squash) August 27, 2024 00:06
@wild-endeavor wild-endeavor merged commit 392f1d9 into master Aug 27, 2024
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants